Add storage for Prometheus using a PersistentVolumeClaim #1226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexellis
force-pushed
the
prometheus-pvc
branch
from
5bd01c2
to
88c0911
Compare
alexellis
force-pushed
the
prometheus-pvc
branch
2 times, most recently
from
d8e7cc8
to
4616767
Compare
welteki
previously approved these changes
Aug 30, 2024
Prior to this change, Prometheus' timeseries data would be lost whenever the chart was upgraded, the Prometheus Pod was rescheduled, or restarted due to a configuration change. Tested with a blank storageClassName with KinD, and the local path provisioner. After creating load with hey, and restarting Prometheus, the invocation metrics remained available. The name of the pvc can also be set, however this is not documented in values.yaml, this may be required for multiple installations of OpenFaaS within the same cluster for testing purposes. Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>
alexellis
force-pushed
the
prometheus-pvc
branch
from
4616767
to
b448d4f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add storage for Prometheus using a PersistentVolumeClaim
Why is this needed?
Prior to this change, Prometheus' timeseries data would be lost whenever the chart was upgraded, the Prometheus Pod was rescheduled, or restarted due to a configuration change.
How Has This Been Tested?
Tested with a blank storageClassName with KinD, and the local path provisioner. After creating load with hey, and restarting Prometheus, the invocation metrics remained available.
Types of changes
Checklist:
I have updated the documentation in the values.yaml file, however this will not be a default, so needs additional documentation in other areas such as the chart README and the Production guide for OpenFaaS Pro.