-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement namespace support using go-sdk #976
Conversation
namespaceCmd.AddCommand(namespaceListCmd) | ||
} | ||
|
||
var namespacesCmd = &cobra.Command{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Potentially make this one hidden? Because we want to have one going forward, it'll still work, but be less confusing (I hope)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. It has been now hidden, as well marked deprecated
Could you check the --gateway flag?
|
f452a2a
to
76053b3
Compare
This is fixed. Used |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you update help messages/formatting?
Signed-off-by: Nitishkumar Singh <nitishkumarsingh71@gmail.com>
76053b3
to
850bbeb
Compare
Tested the CLI after feedback changes, result are ok. Please note output of
output
output
output
output
output
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved
Description
Include
namespace
create, update, get, list and delete support infaas-cli
Motivation and Context
Closes provide namespace mangement capabilities in faas-cli #977
How Has This Been Tested?
All the commands has been tested with local builds
output
output
output
output
output
Types of changes
Checklist:
git commit -s