Download kubeseal via faas-cli cloud seal command #730
Merged
Conversation
Closes: #722 and closes: #724 by @utsavanand2 This is the combination of the approach taken by @utsavanand2 and the guidance offered by @rgee0 and @LucasRoesler combined into a single PR. It also uses the GitHub HTTP website instead of the GitHub API - the GitHub API has a rate-limit of 50 requests per hour and is likely to get exhausted quickly, so this approach removes the issue in #724. Given that there is only one executable needed at this stage, the download command idea was removed in favour of a simple flag. The flag will be updated in the README.md and documentation after the merge and release. Tested with --download and --download-version with an override on MacOS. Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>
Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>
Member
Author
|
Prints version before install command so that the pasted value does not get entered as a password. Corrects typo in the flag. Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>
Member
Author
|
I did consider adding a command for this, but given that the command is already very nested I decided to try a flag. |
alexellis
commented
Nov 28, 2019
| return nil | ||
| } | ||
|
|
||
| func findRelease(url string) (string, error) { |
Member
Author
There was a problem hiding this comment.
This approach can be used to inform users when there is an update for the faas-cli itself. It also doesn't count towards the rate limiting.
Given that the code now exists to check for the release of kubeseal, this can be used to detect version drift of the faas-cli itself. Tested on MacOS with "go build" Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>
Member
Author
|
If folks have comments please feel free to shout and I'd be happy to take them into consideration. |
Member
Author
|
@Waterdrips cc |
Member
Author
|
This might be better than using bash in ofc-bootstrap when we download kubeseal in the same way |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Download kubeseal via faas-cli cloud seal command
Motivation and Context
Closes: #722 and closes: #724 by @utsavanand2 💪 🙏
This is the combination of the approach taken by @utsavanand2 and
the guidance offered by @rgee0 and @LucasRoesler combined into
a single PR. It also uses the GitHub HTTP website instead of the
GitHub API - the GitHub API has a rate-limit of 50 requests per
hour and is likely to get exhausted quickly, so this approach
removes the issue in #724.
Given that there is only one executable needed at this stage, the
download command idea was removed in favour of a simple flag. The
flag will be updated in the README.md and documentation after
the merge and release.
How Has This Been Tested?
Tested with --download and --download-version with an override
on MacOS.
Types of changes
Checklist: