Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EWPP-5135: Include missing classes for site logo. #1545

Merged
merged 2 commits into from
Feb 6, 2025
Merged

EWPP-5135: Include missing classes for site logo. #1545

merged 2 commits into from
Feb 6, 2025

Conversation

fmmribeiro
Copy link
Contributor

`

@fmmribeiro fmmribeiro changed the base branch from 4.x to 5.x February 3, 2025 11:22
22Alexandra
22Alexandra requested changes Feb 3, 2025
View reviewed changes
Copy link
Contributor

@22Alexandra 22Alexandra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix is good, the menu icon in EU on mobile screen is now aligned with the other two icons, but the PR is missing test coverage.
Let's update \Drupal\Tests\oe_theme\Functional\SiteHeaderTest::testSiteHeader.

@upchuk upchuk merged commit 009396f into 5.x Feb 6, 2025
1 check passed
@upchuk upchuk deleted the EWPP-5135 branch February 6, 2025 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nagyad nagyad nagyad approved these changes

@22Alexandra 22Alexandra 22Alexandra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fmmribeiro @nagyad @22Alexandra @upchuk