Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

[stable] Backport constantinople changes #9723

Merged
merged 19 commits into from
Oct 10, 2018

Commits on Oct 10, 2018

  1. Implement EIP-1052 (EXTCODEHASH) and fix several issues in state acco…

    …unt cache (#9234)
    
    * Implement EIP-1052 and fix several issues related to account cache
    
    * Fix jsontests
    
    * Merge two matches together
    
    * Avoid making unnecessary Arc<Vec>
    
    * Address grumbles
    sorpaas authored and andresilva committed Oct 10, 2018
    Configuration menu
    Copy the full SHA
    eefc94e View commit details
    Browse the repository at this point in the history
  2. Comply EIP-86 with the new definition (#9140)

    * Comply EIP-86 with the new CREATE2 opcode
    
    * Fix rpc compile
    
    * Fix interpreter CREATE/CREATE2 stack pop difference
    
    * Add unreachable! to fix compile
    
    * Fix instruction_info
    
    * Fix gas check due to new stack item
    
    * Add new tests in executive
    
    * Fix have_create2 comment
    
    * Remove all unused references of eip86_transition and block_number
    sorpaas authored and andresilva committed Oct 10, 2018
    Configuration menu
    Copy the full SHA
    72594db View commit details
    Browse the repository at this point in the history
  3. Implement KIP4: create2 for wasm (#9277)

    * Basic implementation for kip4
    
    * Add KIP-4 config flags
    
    * typo: docs fix
    
    * Fix args offset
    
    * Add tests for create2
    
    * tests: evm
    
    * Update wasm-tests and fix all gas costs
    
    * Update wasm-tests
    
    * Update wasm-tests and fix gas costs
    sorpaas authored and andresilva committed Oct 10, 2018
    Configuration menu
    Copy the full SHA
    a86e973 View commit details
    Browse the repository at this point in the history
  4. gasleft extern implemented for WASM runtime (kip-6) (#9357)

    * Wasm gasleft extern added
    
    * wasm_gasleft_activation_transition -> kip4_transition
    
    * use kip-6 switch
    
    * gasleft_panic -> gasleft_fail rename
    
    * call_msg_gasleft test added and gas_left agustments because this openethereum/wasm-tests#52
    
    * change .. to _
    
    * fix comment for the have_gasleft param
    
    * update tests (openethereum/wasm-tests@0edbf86)
    lexfrl authored and andresilva committed Oct 10, 2018
    Configuration menu
    Copy the full SHA
    a1e2d94 View commit details
    Browse the repository at this point in the history
  5. Add EIP-1014 transition config flag (#9268)

    * Add EIP-1014 transition config flag
    
    * Remove EIP-86 configs
    
    * Change CREATE2 opcode index to 0xf5
    
    * Move salt to the last item in the stack
    
    * Change sendersaltandaddress scheme to comply with current EIP-1014
    
    * Fix json configs
    
    * Fix create2 test
    
    * Fix deprecated comments
    sorpaas authored and andresilva committed Oct 10, 2018
    Configuration menu
    Copy the full SHA
    b7d9ec6 View commit details
    Browse the repository at this point in the history
  6. EIP 1283: Net gas metering for SSTORE without dirty maps (#9319)

    * Implement last_checkpoint_storage_at
    
    * Add reverted_storage_at for externalities
    
    * sstore_clears_count -> sstore_clears_refund
    
    * Implement eip1283 for evm
    
    * Add eip1283Transition params
    
    * evm: fix tests
    
    * jsontests: fix test
    
    * Return checkpoint index when creating
    
    * Comply with spec Version II
    
    * Fix docs
    
    * Fix jsontests feature compile
    
    * Address grumbles
    
    * Fix no-checkpoint-entry case
    
    * Remove unnecessary expect
    
    * Add test for State::checkpoint_storage_at
    
    * Add executive level test for eip1283
    
    * Hard-code transaction_checkpoint_index to 0
    
    * Fix jsontests
    
    * Add tests for checkpoint discard/revert
    
    * Require checkpoint to be empty for kill_account and commit
    
    * Get code coverage
    
    * Use saturating_add/saturating_sub
    
    * Fix issues in insert_cache
    
    * Clear the state again
    
    * Fix original_storage_at
    
    * Early return for empty RLP trie storage
    
    * Update comments
    
    * Fix borrow_mut issue
    
    * Simplify checkpoint_storage_at if branches
    
    * Better commenting for gas handling code
    
    * Address naming grumbles
    
    * More tests
    
    * Fix an issue in overwrite_with
    
    * Add another test
    
    * Fix comment
    
    * Remove unnecessary bracket
    
    * Move orig to inner if
    
    * Remove test coverage for this PR
    
    * Add tests for executive original value
    
    * Add warn! for an unreachable cause
    sorpaas authored and andresilva committed Oct 10, 2018
    Configuration menu
    Copy the full SHA
    bec26cb View commit details
    Browse the repository at this point in the history
  7. ethash: implement EIP-1234 (#9187)

    5chdn authored and andresilva committed Oct 10, 2018
    Configuration menu
    Copy the full SHA
    b360481 View commit details
    Browse the repository at this point in the history
  8. Update state tests execution model (#9440)

    * Update & fix JSON state tests.
    
    * Update tests to be able to run ethtest at
    021fe3d410773024cd5f0387e62db6e6ec800f32.
    
    - Touch user in state
    - Adjust transaction tests to new json format
    
    * Switch to same commit for submodule ethereum/test as geth (next includes constantinople changes).
    Added test `json_tests::trie::generic::TrieTests_trieanyorder` and a few
    difficulty tests.
    
    * Remove trietestnextprev as it would require to parse differently and
    implement it.
    
    * Support new (shitty) format of transaction tests.
    
    * Ignore junk in ethereum/tests repo.
    
    * Ignore incorrect test.
    
    * Update to a later commit
    
    * Move block number to a constant.
    
    * Fix ZK2 test - touched account should also be cleared.
    
    * Fix conflict resolution
    tomusdrw authored and andresilva committed Oct 10, 2018
    Configuration menu
    Copy the full SHA
    8cb1874 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    6e30af2 View commit details
    Browse the repository at this point in the history
  10. In create memory calculation is the same for create2 because the addi…

    …tional parameter was popped before. (#9522)
    cheme authored and andresilva committed Oct 10, 2018
    Configuration menu
    Copy the full SHA
    05f5e48 View commit details
    Browse the repository at this point in the history
  11. Enable all Constantinople hard fork changes in constantinople_test.js…

    …on (#9505)
    
    * Enable all Constantinople hard fork changes in constantinople_test.json
    
    * Address grumbles
    
    * Remove EIP-210 activation
    
    * 8m -> 5m
    
    * Temporarily add back eip210 transition so we can get test passed
    
    * Add eip210_test and remove eip210 transition from const_test
    sorpaas authored and andresilva committed Oct 10, 2018
    Configuration menu
    Copy the full SHA
    dd5a298 View commit details
    Browse the repository at this point in the history
  12. Add constantinople conf to EvmTestClient. (#9570)

    * Add constantinople conf to EvmTestClient.
    
    * Skip some test to update submodule etheureum/tests submodule to latest.
    
    * Put skipping 'under issue' test behind a feature.
    
    * Change blockReward for const-test to pass ethereum/tests
    
    * Update tests to new constantinple definition (change of reward at block
    5).
    Switch 'reference' to string, that way we can include issues from others
    repo (more flexible)Update tests to new constantinple definition (change
    of reward at block 5).
    Switch 'reference' to string, that way we can include issues from others
    repo (more flexible).
    
    * Fix modexp and bn128_mul gas prices in chain config
    
    * Changes `run_test_path` method to append its directory results (without
    that it stop testing at the first file failure).
    Add some missing tests.
    Add skip for those (block create2 is one hundred percent false but on
    hive we can see that geth and aleth got similar issue for this item).
    
    * retab current.json
    
    * Update reference to parity issue for failing tests.
    cheme authored and andresilva committed Oct 10, 2018
    Configuration menu
    Copy the full SHA
    6ba8eda View commit details
    Browse the repository at this point in the history
  13. Hardfork the testnets (#9562)

    * ethcore: propose hardfork block number 4230000 for ropsten
    
    * ethcore: propose hardfork block number 9000000 for kovan
    
    * ethcore: enable kip-4 and kip-6 on kovan
    
    * etcore: bump kovan hardfork to block 9.2M
    
    * ethcore: fix ropsten constantinople block number to 4.2M
    
    * ethcore: disable difficulty_test_ropsten until ethereum/tests are updated upstream
    5chdn authored and andresilva committed Oct 10, 2018
    Configuration menu
    Copy the full SHA
    c898463 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    5061017 View commit details
    Browse the repository at this point in the history
  15. Implement CREATE2 gas changes and fix some potential overflowing (#9694)

    * Implement CREATE2 gas changes and fix some potential overflowing
    
    * Ignore create2 state tests
    
    * Split CREATE and CREATE2 in gasometer
    
    * Generalize rounding (x + 31) / 32 to to_word_size
    sorpaas authored and andresilva committed Oct 10, 2018
    Configuration menu
    Copy the full SHA
    1556356 View commit details
    Browse the repository at this point in the history
  16. ethcore: delay ropsten hardfork (#9704)

    5chdn authored and andresilva committed Oct 10, 2018
    Configuration menu
    Copy the full SHA
    c079497 View commit details
    Browse the repository at this point in the history
  17. Add hardcoded headers (#9730)

    * add foundation hardcoded header #6486017
    
    * add ropsten hardcoded headers #4202497
    
    * add kovan hardcoded headers #9023489
    Tbaut authored and andresilva committed Oct 10, 2018
    Configuration menu
    Copy the full SHA
    4c74b4b View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    07ccad5 View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    2b3d34f View commit details
    Browse the repository at this point in the history