This repository was archived by the owner on Nov 6, 2020. It is now read-only.
removed redundant clone before each block import #9683
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
debris
added
A0-pleasereview 🤓
debris
commented
Oct 1, 2018
| bail!(EthcoreErrorKind::Block(BlockError::UnknownParent(unverified.parent_hash()))); | ||
| } | ||
|
|
||
| let raw = unverified.bytes.clone(); |
There was a problem hiding this comment.
redundant block clone
ordian
approved these changes
Oct 1, 2018
ethcore/src/client/client.rs
Outdated
| // we only care about block errors (not import errors) | ||
| Err(EthcoreError(EthcoreErrorKind::Block(err), _))=> { | ||
| self.importer.bad_blocks.report(raw, format!("{:?}", err)); | ||
| Err((block, EthcoreError(EthcoreErrorKind::Block(err), _)))=> { |
ordian
added
A8-looksgood 🦄
sorpaas
approved these changes
Oct 3, 2018
@ordian you cannot do that cause |
dvdplm
added a commit
that referenced
this pull request
Oct 9, 2018
…mon-deps * origin/master: fix (light/provider) : Make `read_only executions` read-only (#9591) ethcore: fix detection of major import (#9552) return 0 on error (#9705) ethcore: delay ropsten hardfork (#9704) make instantSeal engine backwards compatible, closes #9696 (#9700) Implement CREATE2 gas changes and fix some potential overflowing (#9694) Don't hash the init_code of CREATE. (#9688) ethcore: minor optimization of modexp by using LR exponentiation (#9697) removed redundant clone before each block import (#9683)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.