This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
refactor(fetch) : light use only one DNS thread
#9647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niklasad1
added
A0-pleasereview 🤓
ascjones
reviewed
Sep 26, 2018
util/fetch/src/client.rs
Outdated
| thread::Builder::new().name("fetch".into()).spawn(move || { | ||
| let mut core = match reactor::Core::new() { | ||
| Ok(c) => c, | ||
| Err(e) => return tx_start.send(Err(e)).unwrap_or(()) | ||
| }; | ||
|
|
||
| let handle = core.handle(); | ||
| let number_dns_threads = if is_light { 1 } else { 4 }; |
There was a problem hiding this comment.
Instead of passing the flag down you could pass the number of threads as a parameter.
There was a problem hiding this comment.
That's better, will change it!
parity/run.rs
Outdated
| @@ -283,7 +283,7 @@ fn execute_light_impl(cmd: RunCmd, logger: Arc<RotatingLogger>) -> Result<Runnin | |||
| let cpu_pool = CpuPool::new(4); | |||
|
|
|||
| // fetch service | |||
| let fetch = fetch::Client::new().map_err(|e| format!("Error starting fetch client: {:?}", e))?; | |||
| let fetch = fetch::Client::new(cmd.light).map_err(|e| format!("Error starting fetch client: {:?}", e))?; | |||
There was a problem hiding this comment.
This will always be true so could just pass in 1 here
parity/run.rs
Outdated
| @@ -477,7 +477,7 @@ fn execute_impl<Cr, Rr>(cmd: RunCmd, logger: Arc<RotatingLogger>, on_client_rq: | |||
| let event_loop = EventLoop::spawn(); | |||
|
|
|||
| // fetch service | |||
| let fetch = fetch::Client::new().map_err(|e| format!("Error starting fetch client: {:?}", e))?; | |||
| let fetch = fetch::Client::new(cmd.light).map_err(|e| format!("Error starting fetch client: {:?}", e))?; | |||
There was a problem hiding this comment.
This will always be false so could just pass in 4 here
niklasad1
force-pushed
the
refactor/fetch-one-thread-light
branch
from
2bb4b46
to
ac3e528
Compare
ordian
approved these changes
Sep 27, 2018
ordian
added
A8-looksgood 🦄
tomusdrw
approved these changes
Sep 27, 2018
| const VERIFY_PASSWORD_HINT: &str = "Make sure valid password is present in files passed using `--password` or in the configuration file."; | ||
|
|
||
| // Full client number of DNS threads | ||
| const FETCH_FULL_NUM_DNS_THREADS: usize = 4; |
There was a problem hiding this comment.
I doubt we actually need all 4 for the full node either. But fine with keeping it the same for backward compatibility.
dvdplm
added a commit
that referenced
this pull request
Oct 2, 2018
…mon-deps * origin/master: CI: Remove unnecessary pipes (#9681) test.sh: use cargo --target for platforms other than linux, win or mac (#9650) ci: fix push script (#9679) Hardfork the testnets (#9562) Calculate sha3 instead of sha256 for push-release. (#9673) ethcore-io retries failed work steal (#9651) fix(light_fetch): avoid race with BlockNumber::Latest (#9665) Test fix for windows cache name... (#9658) refactor(fetch) : light use only one `DNS` thread (#9647)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to close #9623