This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
parity: print correct keys path on startup #9501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5chdn
added
A0-pleasereview 🤓
|
tomusdrw
approved these changes
Sep 8, 2018
tomusdrw
added
A8-looksgood 🦄
|
@5chdn rebase on top of master to fix CI check |
ordian
approved these changes
Sep 8, 2018
This was referenced Sep 8, 2018
5chdn
added a commit
that referenced
this pull request
Sep 8, 2018
5chdn
added a commit
that referenced
this pull request
Sep 8, 2018
ChainSafeSystems
pushed a commit
to goerli/parity-goerli
that referenced
this pull request
Sep 9, 2018
* rpc(debug_getBadBlocks): fix test (openethereum#9502) * Generalized blockReward and difficultyBombDelays config (openethereum#9480) * Implement multi blockReward * Implement difficultyBombDelays * Fix json crate compile * json keys can only be string * parity: print correct keys path on startup (openethereum#9501)
5chdn
added a commit
that referenced
this pull request
Sep 10, 2018
* parity-version: bump stable to 1.11.11 * Update tobalaba.json (#9419) * Update hardcoded sync (#9421) - Update foundation hardcoded header to block 6219777 - Update ropsten hardcoded header to block 3917825 - Update kovan hardcoded header to block 8511489 * parity: print correct keys path on startup (#9501) * Only check warp syncing for eth_getWorks (#9484) * Only check warp syncing for eth_getWorks * Use SyncStatus::is_snapshot_syncing
5chdn
added a commit
that referenced
this pull request
Sep 10, 2018
* parity-version: bump beta to 2.0.4 * [light/jsonrpc] Provide the actual account for `eth_coinbase` RPC and unify error handeling for light and full client (#9383) * Provide the actual `account` for eth_coinbase The previous implementation always provided the `zero address` on `eth_coinbase` RPC. Now, instead the actual address is returned on success or an error when no account(s) is found! * full client `eth_coinbase` return err In the full-client return an error when no account is found instead of returning the `zero address` * Remove needless blocks on single import * Remove needless `static` lifetime on const * Fix `rpc_eth_author` test * parity: print correct keys path on startup (#9501) * aura: don't report skipped primaries when empty steps are enabled (#9435) * Only check warp syncing for eth_getWorks (#9484) * Only check warp syncing for eth_getWorks * Use SyncStatus::is_snapshot_syncing * Fix Snapshot restoration failure on Windows (#9491) * Close Blooms DB files before DB restoration * PR Grumbles I * PR Grumble * Grumble
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #9500
It prints the wrong key path using the spec name but uses the correct key path using the spec data dir. this fixes the startup notification.
hello from ethberlin <3