Skip to content
This repository was archived by the owner on Nov 6, 2020. It is now read-only.

Delete user_defaults when using 'db kill' (#8550) #9081

Closed
wants to merge 1 commit into from

Conversation

mttmartin
Copy link
Contributor

This should fix #8550.

@parity-cla-bot
Copy link

It looks like this contributor signed our Contributor License Agreement. 👍

Many thanks,

Parity Technologies CLA Bot

@5chdn 5chdn added this to the 2.0 milestone Jul 9, 2018
@5chdn 5chdn added A0-pleasereview 🤓 Pull request needs code review. M2-config 📂 Chain specifications and node configurations. labels Jul 9, 2018
Copy link
Collaborator

@dvdplm dvdplm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@5chdn 5chdn added the A1-onice 🌨 Pull request is reviewed well, but should not yet be merged. label Jul 10, 2018
@5chdn 5chdn modified the milestones: 2.0, 2.1 Jul 10, 2018
@5chdn 5chdn removed the A1-onice 🌨 Pull request is reviewed well, but should not yet be merged. label Jul 11, 2018
@5chdn 5chdn requested a review from ordian July 13, 2018 10:17
@5chdn 5chdn added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Jul 13, 2018
@andresilva
Copy link
Contributor

I don't think we should merge this. See my comment here #8550 (comment).

@5chdn
Copy link
Contributor

5chdn commented Jul 16, 2018

Closing in favor of #9130 - thanks @mttmartin anyways!

@5chdn 5chdn closed this Jul 16, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well. M2-config 📂 Chain specifications and node configurations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delete user_defaults when doing db kill
5 participants