Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Print warnings when fetching pending blocks #8711

Merged
merged 3 commits into from
Jun 1, 2018
Merged

Print warnings when fetching pending blocks #8711

merged 3 commits into from
Jun 1, 2018

Commits on May 24, 2018

  1. Lots of println to figure out what eth_getBlockByNumber does/should do

    @dvdplm
    dvdplm committed May 24, 2018
    Configuration menu
    Copy the full SHA
    3647789 View commit details
    Browse the repository at this point in the history

  2. Remove debugging

    @dvdplm
    dvdplm committed May 24, 2018
    Configuration menu
    Copy the full SHA
    c23ce50 View commit details
    Browse the repository at this point in the history

  3. Print warnings when fetching pending blocks 

    When calling `eth_getBlockByNumber` with `pending`, we now print a deprecation warning and:

* if a pending block is found, use it to respond
* if no pending block is found, respond as if if was a request for `Latest`

Addresses issue #8703 (not sure if it's enough to close it tbh)
    @dvdplm
    dvdplm committed May 24, 2018
    Configuration menu
    Copy the full SHA
    aef492e View commit details
    Browse the repository at this point in the history