Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

[beta] Backports #8624

Merged
merged 19 commits into from
May 15, 2018
Merged

[beta] Backports #8624

merged 19 commits into from
May 15, 2018

Commits on May 14, 2018

  1. Trace precompiled contracts when the transfer value is not zero (#8486) 

    * Trace precompiled contracts when the transfer value is not zero

* Add tests for precompiled CALL tracing

* Use byzantium test machine for the new test

* Add notes in comments on why we don't trace all precompileds

* Use is_transferred instead of transferred
    @sorpaas @ascjones
    sorpaas authored and ascjones committed May 14, 2018
    Configuration menu
    Copy the full SHA
    586056c View commit details
    Browse the repository at this point in the history

  2. Return error if RLP size of transaction exceeds the limit (#8473) 

    * Return error if RLP size of transaction exceeds the limit

* Review comments fixed

* RLP check moved to verifier, corresponding pool test added
    @grbIzl @ascjones
    grbIzl authored and ascjones committed May 14, 2018
    Configuration menu
    Copy the full SHA
    954eaa9 View commit details
    Browse the repository at this point in the history

  3. Don't block sync when importing old blocks (#8530) 

    * Alter IO queueing.

* Don't require IoMessages to be Clone

* Ancient blocks imported via IoChannel.

* Get rid of private transactions io message.

* Get rid of deadlock and fix disconnected handler.

* Revert to old disconnect condition.

* Fix tests.

* Fix deadlock.
    @tomusdrw @ascjones
    tomusdrw authored and ascjones committed May 14, 2018
    Configuration menu
    Copy the full SHA
    4052728 View commit details
    Browse the repository at this point in the history

  4. Refactoring ethcore-sync - Fixing warp-sync barrier (#8543) 

    * Start dividing sync chain : first supplier method

* WIP - updated chain sync supplier

* Finish refactoring the Chain Sync Supplier

* Create Chain Sync Requester

* Add Propagator for Chain Sync

* Add the Chain Sync Handler

* Move tests from mod -> handler

* Move tests to propagator

* Refactor SyncRequester arguments

* Refactoring peer fork header handler

* Fix wrong highest block number in snapshot sync

* Small refactor...

* Address PR grumbles

* Retry failed CI job

* Fix tests

* PR Grumbles
    @ngotchac @ascjones
    ngotchac authored and ascjones committed May 14, 2018
    Configuration menu
    Copy the full SHA
    70c6351 View commit details
    Browse the repository at this point in the history

  5. Handle socket address parsing errors (#8545) 

    Unpack errors and check for io::ErrorKind::InvalidInput and return our own AddressParse error. Remove the foreign link to std::net::AddrParseError and add an `impl From` for that error. Test parsing properly.
    @dvdplm @ascjones
    dvdplm authored and ascjones committed May 14, 2018
    Configuration menu
    Copy the full SHA
    7ee4246 View commit details
    Browse the repository at this point in the history

  6. Fix packet count when talking with PAR2 peers (#8555) 

    * Support diferent packet counts in different protocol versions.

* Fix light timeouts and eclipse protection.

* Fix devp2p tests.

* Fix whisper-cli compilation.

* Fix compilation.

* Fix ethcore-sync tests.

* Revert "Fix light timeouts and eclipse protection."

This reverts commit 06285ea.

* Increase timeouts.
    @tomusdrw @ascjones
    tomusdrw authored and ascjones committed May 14, 2018
    Configuration menu
    Copy the full SHA
    b26f539 View commit details
    Browse the repository at this point in the history

  7. Add whisper CLI to the pipelines (#8578) 

    * Add whisper CLI to the pipelines

* Address todo, ref #8579
    @5chdn @ascjones
    5chdn authored and ascjones committed May 14, 2018
    Configuration menu
    Copy the full SHA
    a69fca9 View commit details
    Browse the repository at this point in the history

  8. Rename whisper-cli binary to whisper (#8579) 

    * rename whisper-cli binary to whisper

* fix tests
    @niklasad1 @ascjones
    niklasad1 authored and ascjones committed May 14, 2018
    Configuration menu
    Copy the full SHA
    3a5b016 View commit details
    Browse the repository at this point in the history

  9. Remove manually added text to the errors (#8595) 

    These messages were confusing for the users especially the help message.
    @niklasad1 @ascjones
    niklasad1 authored and ascjones committed May 14, 2018
    Configuration menu
    Copy the full SHA
    f65ef0e View commit details
    Browse the repository at this point in the history

  10. Fix account list double 0x display (#8596) 

    * Remove unused self import

* Fix account list double 0x display
    @sorpaas @ascjones
    sorpaas authored and ascjones committed May 14, 2018
    Configuration menu
    Copy the full SHA
    06c94ce View commit details
    Browse the repository at this point in the history

  11. Fix BlockReward contract "arithmetic operation overflow" (#8611) 

    * Fix BlockReward contract "arithmetic operation overflow"

* Add docs on how execute_as_system works

* Fix typo
    @sorpaas @ascjones
    sorpaas authored and ascjones committed May 14, 2018
    Configuration menu
    Copy the full SHA
    53b1b7f View commit details
    Browse the repository at this point in the history

  12. Rlp decode returns Result (#8527) 

    rlp::decode returns Result

Make a best effort to handle decoding errors gracefully throughout the code, using `expect` where the value is guaranteed to be valid (and in other places where it makes sense).
    @dvdplm @ascjones
    dvdplm authored and ascjones committed May 14, 2018
    Configuration menu
    Copy the full SHA
    19e090e View commit details
    Browse the repository at this point in the history

  13. Remove expect (#8536) 

    * Remove expect and propagate rlp::DecoderErrors as TrieErrors
    @dvdplm @ascjones
    dvdplm authored and ascjones committed May 14, 2018
    Configuration menu
    Copy the full SHA
    9a309f8 View commit details
    Browse the repository at this point in the history

  14. Decoding headers can fail (#8570) 

    * rlp::decode returns Result

* Fix journaldb to handle rlp::decode Result

* Fix ethcore to work with rlp::decode returning Result

* Light client handles rlp::decode returning Result

* Fix tests in rlp_derive

* Fix tests

* Cleanup

* cleanup

* Allow panic rather than breaking out of iterator

* Let decoding failures when reading from disk blow up

* syntax

* Fix the trivial grumbles

* Fix failing tests

* Make Account::from_rlp return Result

* Syntx, sigh

* Temp-fix for decoding failures

* Header::decode returns Result

Handle new return type throughout the code base.

* Do not continue reading from the DB when a value could not be read

* Fix tests

* Handle header decoding in light_sync

* Handling header decoding errors

* Let the DecodeError bubble up unchanged

* Remove redundant error conversion
    @dvdplm @ascjones
    dvdplm authored and ascjones committed May 14, 2018
    Configuration menu
    Copy the full SHA
    b4a691a View commit details
    Browse the repository at this point in the history

  15. fix compiler warning (#8590)

    @niklasad1 @ascjones
    niklasad1 authored and ascjones committed May 14, 2018
    Configuration menu
    Copy the full SHA
    52f8247 View commit details
    Browse the repository at this point in the history

  16. Attempt to fix intermittent test failures (#8584) 

    Occasionally should_return_correct_nonces_when_dropped_because_of_limit fails, possibly because of multiple threads competing to finish. See CI logs here for an example: https://gitlab.parity.io/parity/parity/-/jobs/86738
    @dvdplm @ascjones
    dvdplm authored and ascjones committed May 14, 2018
    Configuration menu
    Copy the full SHA
    9623840 View commit details
    Browse the repository at this point in the history

  17. block_header can fail so return Result (#8581) 

    * block_header can fail so return Result

* Restore previous return type based on feedback

* Fix failing doc tests running on non-code
    @dvdplm @ascjones
    dvdplm authored and ascjones committed May 14, 2018
    Configuration menu
    Copy the full SHA
    78edfe5 View commit details
    Browse the repository at this point in the history

  18. Block::decode() returns Result (#8586)

    @dvdplm @ascjones
    dvdplm authored and ascjones committed May 14, 2018
    Configuration menu
    Copy the full SHA
    a315952 View commit details
    Browse the repository at this point in the history

  19. Gitlab test script fixes (#8573) 

    * Exclude /docs from modified files.

* Ensure all references in the working tree are available

* Remove duplicated line from test script
    @5chdn @ascjones
    5chdn authored and ascjones committed May 14, 2018
    Configuration menu
    Copy the full SHA
    589090e View commit details
    Browse the repository at this point in the history