Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

bigint upgraded to version 3.0 #5986

Merged
merged 3 commits into from
Jul 6, 2017
Merged

bigint upgraded to version 3.0 #5986

merged 3 commits into from
Jul 6, 2017

Conversation

debris
Copy link
Collaborator

@debris debris commented Jul 4, 2017

changes:

  • upgraded bigint crate to version 3.0.0
  • moved util/benches/bigint.rs to bigint repo
  • updated ethcore-bigint so it does not depend on heapsize crate by default, fixes Can't use ethcore_bigint within dylib on macOS #5964
  • replaced deprecated rustc-serialize with smaller rustc-hex where possible. rustc-serialize is left only where it's used for json/cli decoding. I will make a separate issue for this - Migrate to serde 1.0 #5988
  • removed global rustc_serialize reexports from util/src/standard.rs

@debris debris requested a review from rphmeier July 4, 2017 10:24
@arkpar arkpar added the A8-looksgood 🦄 Pull request is reviewed well. label Jul 4, 2017
@@ -122,7 +122,7 @@ impl trace::VMTracer for Informant {
fn prepare_subtrace(&self, code: &[u8]) -> Self where Self: Sized {
let mut vm = Informant::default();
vm.depth = self.depth + 1;
vm.code = code.into_vec();
vm.code = code.to_vec();
Copy link
Collaborator Author

@debris debris Jul 4, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this change is unrelated to this pr, but was needed to compile evmbin

created a separate issue for this: #5989

@NikVolf NikVolf added A4-awaitingci 🤖 Pull request is waiting for changes on the CI to complete tests before review/merge can begin. M4-core ⛓ Core client code / Rust. labels Jul 4, 2017
@debris debris removed the A4-awaitingci 🤖 Pull request is waiting for changes on the CI to complete tests before review/merge can begin. label Jul 6, 2017
@tomusdrw tomusdrw merged commit 46183b1 into master Jul 6, 2017
@tomusdrw tomusdrw deleted the bigint3 branch July 6, 2017 09:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well. M4-core ⛓ Core client code / Rust.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't use ethcore_bigint within dylib on macOS
4 participants