Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Extract the Engine trait #10958

Merged
merged 49 commits into from
Aug 15, 2019
Merged

Extract the Engine trait #10958

merged 49 commits into from
Aug 15, 2019

Commits on Aug 6, 2019

  1. Add client-traits crate 

    Move the BlockInfo trait to new crate
    @dvdplm
    dvdplm committed Aug 6, 2019
    Configuration menu
    Copy the full SHA
    ddeef45 View commit details
    Browse the repository at this point in the history

  2. New crate machine 

    Contains code extracted from ethcore that defines `Machine`, `Externalities` and other execution related code.
    @dvdplm
    dvdplm committed Aug 6, 2019
    Configuration menu
    Copy the full SHA
    0d49c45 View commit details
    Browse the repository at this point in the history

  3. Use new machine and client-traits crates in ethcore

    @dvdplm
    dvdplm committed Aug 6, 2019
    Configuration menu
    Copy the full SHA
    0465e6b View commit details
    Browse the repository at this point in the history

  4. Use new crates machine and client-traits instead of ethcore where app… 

    …ropriate
    @dvdplm
    dvdplm committed Aug 6, 2019
    Configuration menu
    Copy the full SHA
    50ca45a View commit details
    Browse the repository at this point in the history

  5. Fix tests

    @dvdplm
    dvdplm committed Aug 6, 2019
    Configuration menu
    Copy the full SHA
    29d4095 View commit details
    Browse the repository at this point in the history

  6. Don't re-export so many types from ethcore::client

    @dvdplm
    dvdplm committed Aug 6, 2019
    Configuration menu
    Copy the full SHA
    cd6e0e2 View commit details
    Browse the repository at this point in the history

  7. Fixing more fallout from removing re-export

    @dvdplm
    dvdplm committed Aug 6, 2019
    Configuration menu
    Copy the full SHA
    2477cbd View commit details
    Browse the repository at this point in the history

  8. Merge branch 'master' into dp/chore/move-machine-to-own-crate 

    * master:
  Allow default block parameter to be blockHash (#10932)
  Enable sealing when engine is ready (#10938)
  Fix some warnings and typos. (#10941)
    @dvdplm
    dvdplm committed Aug 6, 2019
    Configuration menu
    Copy the full SHA
    51ba2f4 View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2019

  1. fix test

    @dvdplm
    dvdplm committed Aug 7, 2019
    Configuration menu
    Copy the full SHA
    c84a01f View commit details
    Browse the repository at this point in the history

  2. More fallout from not re-exporting types

    @dvdplm
    dvdplm committed Aug 7, 2019
    Configuration menu
    Copy the full SHA
    f2497f4 View commit details
    Browse the repository at this point in the history

  3. Add some docs

    @dvdplm
    dvdplm committed Aug 7, 2019
    Configuration menu
    Copy the full SHA
    1e43534 View commit details
    Browse the repository at this point in the history

  4. cleanup

    @dvdplm
    dvdplm committed Aug 7, 2019
    Configuration menu
    Copy the full SHA
    6d83cf2 View commit details
    Browse the repository at this point in the history

  5. import the macro edition style

    @dvdplm
    dvdplm committed Aug 7, 2019
    Configuration menu
    Copy the full SHA
    e04d188 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'master' into dp/chore/move-machine-to-own-crate 

    * master:
  unify loading spec && further spec cleanups (#10948)
  refactor: Refactor evmbin CLI (#10742)
  journaldb changes (#10929)
    @dvdplm
    dvdplm committed Aug 7, 2019
    Configuration menu
    Copy the full SHA
    b6e91de View commit details
    Browse the repository at this point in the history

  7. Tweak docs

    @dvdplm
    dvdplm committed Aug 7, 2019
    Configuration menu
    Copy the full SHA
    bac7268 View commit details
    Browse the repository at this point in the history

  8. Add missing import

    @dvdplm
    dvdplm committed Aug 7, 2019
    Configuration menu
    Copy the full SHA
    978eb88 View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2019

  1. Merge branch 'master' into dp/chore/move-machine-to-own-crate 

    * master:
  Fix compiler warnings in util/io and upgrade to edition 2018 Upgrade mio to latest (#10953)
    @dvdplm
    dvdplm committed Aug 8, 2019
    Configuration menu
    Copy the full SHA
    d6273a7 View commit details
    Browse the repository at this point in the history

  2. remove unused ethabi_derive imports

    @dvdplm
    dvdplm committed Aug 8, 2019
    Configuration menu
    Copy the full SHA
    18d6a94 View commit details
    Browse the repository at this point in the history

  3. Use latest ethabi-contract

    @dvdplm
    dvdplm committed Aug 8, 2019
    Configuration menu
    Copy the full SHA
    d5700d9 View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2019

  1. Move many traits from ethcore/client/traits to client-traits crate 

    Initial version of extracted Engine trait
    @dvdplm
    dvdplm committed Aug 9, 2019
    Configuration menu
    Copy the full SHA
    83bb140 View commit details
    Browse the repository at this point in the history

  2. Move snapshot related traits to the engine crate (eew)

    @dvdplm
    dvdplm committed Aug 9, 2019
    Configuration menu
    Copy the full SHA
    d96fff3 View commit details
    Browse the repository at this point in the history

  3. Move a few snapshot related types to common_types 

    Cleanup Executed as exported from machine crate
    @dvdplm
    dvdplm committed Aug 9, 2019
    Configuration menu
    Copy the full SHA
    33aa152 View commit details
    Browse the repository at this point in the history

  4. fix warning

    @dvdplm
    dvdplm committed Aug 9, 2019
    Configuration menu
    Copy the full SHA
    9b70856 View commit details
    Browse the repository at this point in the history

  5. Gradually introduce new engine crate: snapshot

    @dvdplm
    dvdplm committed Aug 9, 2019
    Configuration menu
    Copy the full SHA
    f76e5ed View commit details
    Browse the repository at this point in the history

  6. ethcore typechecks with new engine crate

    @dvdplm
    dvdplm committed Aug 9, 2019
    Configuration menu
    Copy the full SHA
    5b3a8ca View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2019

  1. Sort out types outside ethcore

    @dvdplm
    dvdplm committed Aug 10, 2019
    Configuration menu
    Copy the full SHA
    cecd69c View commit details
    Browse the repository at this point in the history

  2. Add an EpochVerifier to ethash and use that in Engine.epoch_verifier() 

    Cleanup
    @dvdplm
    dvdplm committed Aug 10, 2019
    Configuration menu
    Copy the full SHA
    c5ab534 View commit details
    Browse the repository at this point in the history

  3. Document pub members

    @dvdplm
    dvdplm committed Aug 10, 2019
    Configuration menu
    Copy the full SHA
    45c0497 View commit details
    Browse the repository at this point in the history

  4. Sort out tests 

    Sort out default impls for EpochVerifier
    @dvdplm
    dvdplm committed Aug 10, 2019
    Configuration menu
    Copy the full SHA
    b11a21f View commit details
    Browse the repository at this point in the history

  5. Add test-helpers feature and move EngineSigner impl to the right place

    @dvdplm
    dvdplm committed Aug 10, 2019
    Configuration menu
    Copy the full SHA
    af485cc View commit details
    Browse the repository at this point in the history

  6. Sort out tests

    @dvdplm
    dvdplm committed Aug 10, 2019
    Configuration menu
    Copy the full SHA
    f617bcb View commit details
    Browse the repository at this point in the history

  7. Sort out tests and refactor verification types

    @dvdplm
    dvdplm committed Aug 10, 2019
    Configuration menu
    Copy the full SHA
    64b5c60 View commit details
    Browse the repository at this point in the history

  8. Fix missing traits

    @dvdplm
    dvdplm committed Aug 10, 2019
    Configuration menu
    Copy the full SHA
    b1b6b46 View commit details
    Browse the repository at this point in the history

  9. More missing traits 

    Fix Histogram
    @dvdplm
    dvdplm committed Aug 10, 2019
    Configuration menu
    Copy the full SHA
    881b71f View commit details
    Browse the repository at this point in the history

  10. Fix tests and cleanup

    @dvdplm
    dvdplm committed Aug 10, 2019
    Configuration menu
    Copy the full SHA
    ddca9ee View commit details
    Browse the repository at this point in the history

  11. cleanup

    @dvdplm
    dvdplm committed Aug 10, 2019
    Configuration menu
    Copy the full SHA
    d7d3f4b View commit details
    Browse the repository at this point in the history

  12. Put back needed logger import

    @dvdplm
    dvdplm committed Aug 10, 2019
    Configuration menu
    Copy the full SHA
    b2f8be6 View commit details
    Browse the repository at this point in the history

  13. Don't rexport common_types from ethcore/src/client 

    Don't export ethcore::client::*
    @dvdplm
    dvdplm committed Aug 10, 2019
    Configuration menu
    Copy the full SHA
    8ab2a02 View commit details
    Browse the repository at this point in the history

  14. Remove files no longer used 

    Use types from the engine crate
Explicit exports from engine::engine
    @dvdplm
    dvdplm committed Aug 10, 2019
    Configuration menu
    Copy the full SHA
    4aef5f2 View commit details
    Browse the repository at this point in the history

  15. Get rid of itertools

    @dvdplm
    dvdplm committed Aug 10, 2019
    Configuration menu
    Copy the full SHA
    951f63e View commit details
    Browse the repository at this point in the history

  16. Move a few more traits from ethcore to client-traits: BlockChainReset… 

    …, ScheduleInfo, StateClient
    @dvdplm
    dvdplm committed Aug 10, 2019
    Configuration menu
    Copy the full SHA
    1c42cc1 View commit details
    Browse the repository at this point in the history

  17. Move ProvingBlockChainClient to client-traits

    @dvdplm
    dvdplm committed Aug 10, 2019
    Configuration menu
    Copy the full SHA
    07b1c2d View commit details
    Browse the repository at this point in the history

  18. Don't re-export ForkChoice and Transition from ethcore

    @dvdplm
    dvdplm committed Aug 10, 2019
    Configuration menu
    Copy the full SHA
    7e5e4bc View commit details
    Browse the repository at this point in the history

Commits on Aug 13, 2019

  1. Address grumbles: sort imports, remove commented out code

    @dvdplm
    dvdplm committed Aug 13, 2019
    Configuration menu
    Copy the full SHA
    b244bfb View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into dp/chore/extract-engine-trait 

    * master:
  Extract Machine from ethcore (#10949)
  removed redundant state_root function from spec, improve spec error types (#10955)
  Add support for Energy Web Foundation's new chains (#10957)
  [evmbin] add more tests to main.rs (#10956)
    @dvdplm
    dvdplm committed Aug 13, 2019
    Configuration menu
    Copy the full SHA
    37be7b2 View commit details
    Browse the repository at this point in the history

  3. Fix merge resolution error

    @dvdplm
    dvdplm committed Aug 13, 2019
    Configuration menu
    Copy the full SHA
    88cfa7f View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2019

  1. Merge branch 'master' into dp/chore/extract-engine-trait 

    * master:
  Verify transaction against its block during import (#10954)
  [evmbin] fix compilation (#10976)
  Update to latest trie version. (#10972)
  [blooms-db] Fix benchmarks (#10974)
  Fix ethcore/benches build. (#10964)
  tx-pool: accept local tx with higher gas price when pool full (#10901)
  Disable unsyncable expanse chain (#10926)
    @ordian
    ordian committed Aug 15, 2019
    Configuration menu
    Copy the full SHA
    dcaf256 View commit details
    Browse the repository at this point in the history

  2. merge failure

    @dvdplm
    dvdplm committed Aug 15, 2019
    Configuration menu
    Copy the full SHA
    60a03b2 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into dp/chore/extract-engine-trait 

    * master:
  [.gitlab.yml] cargo check ethcore benches (#10965)
    @dvdplm
    dvdplm committed Aug 15, 2019
    Configuration menu
    Copy the full SHA
    c75738e View commit details
    Browse the repository at this point in the history