Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

whisper is no longer a part of parity-ethereum repo #10855

Merged
merged 8 commits into from
Jul 12, 2019
Merged

whisper is no longer a part of parity-ethereum repo #10855

merged 8 commits into from
Jul 12, 2019

Conversation

debris
Copy link
Collaborator

@debris debris commented Jul 8, 2019

it's moved over here: https://github.com/paritytech/whisper

  • several README files still need to be updated

@debris debris added A0-pleasereview 🤓 Pull request needs code review. M4-core ⛓ Core client code / Rust. labels Jul 8, 2019
@debris debris requested a review from dvdplm July 8, 2019 08:53
dvdplm
dvdplm approved these changes Jul 8, 2019
View reviewed changes
Copy link
Collaborator

@dvdplm dvdplm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding a link to the new repo.

parity/cli/mod.rs Outdated Show resolved Hide resolved
@ordian ordian added this to the 2.7 milestone Jul 8, 2019
@dvdplm dvdplm added A7-looksgoodtestsfail 🤖 Pull request is reviewed well, but cannot be merged due to tests failing. and removed A0-pleasereview 🤓 Pull request needs code review. labels Jul 8, 2019
@dvdplm
Copy link
Collaborator

dvdplm commented Jul 8, 2019

cc @ltfschoen you have a few pending PRs in this area. Do you think you can move them over to the new repo and also take a look at the Readme(s)/docs/wiki?

@ltfschoen
Copy link
Contributor

cc @ltfschoen you have a few pending PRs in this area. Do you think you can move them over to the new repo and also take a look at the Readme(s)/docs/wiki?

Yes, but I'll wait for this to get finalised and merged first, then I'll makes those changes in separate PRs

@debris debris added A8-looksgood 🦄 Pull request is reviewed well. and removed A7-looksgoodtestsfail 🤖 Pull request is reviewed well, but cannot be merged due to tests failing. labels Jul 8, 2019
@debris
Copy link
Collaborator Author

debris commented Jul 8, 2019

@ordian please review :)

ordian
ordian approved these changes Jul 8, 2019
View reviewed changes
Copy link
Collaborator

@ordian ordian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

several README files still need to be updated

  • README.md
  • evmbin/README.md
  • accounts/ethkey/README.md
  • accounts/ethstore/README.md

separate PR?

scripts/gitlab/build-linux.sh
@@ -27,7 +27,6 @@ else
time cargo build --target $CARGO_TARGET --verbose --color=always --release -p evmbin
time cargo build --target $CARGO_TARGET --verbose --color=always --release -p ethstore-cli
time cargo build --target $CARGO_TARGET --verbose --color=always --release -p ethkey-cli
time cargo build --target $CARGO_TARGET --verbose --color=always --release -p whisper-cli
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does that mean we no longer provide whisper binaries?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes.

cc @s3krit

ordian
ordian reviewed Jul 8, 2019
View reviewed changes
parity/run.rs Outdated Show resolved Hide resolved
@dvdplm
Copy link
Collaborator

dvdplm commented Jul 8, 2019

separate PR?

I'd prefer it happened here tbh. It can be useful to have the extraction all in one commit for posterity.

@dvdplm
Copy link
Collaborator

dvdplm commented Jul 9, 2019

@debris there's also the config generator to cleanup: paritytech/parity-config-generator#50

@dvdplm dvdplm mentioned this pull request Jul 9, 2019
Open
ordian
ordian reviewed Jul 10, 2019
View reviewed changes
parity/deprecated.rs Outdated Show resolved Hide resolved
@debris @ordian
Update parity/deprecated.rs
4fce912 
Co-Authored-By: Andronik Ordian <write@reusable.software>
@jam10o-new jam10o-new added the B7-releasenotes 📜 Changes should be mentioned in the release notes of the next minor version release. label Jul 11, 2019
@debris debris merged commit cfe826f into master Jul 12, 2019
@debris debris deleted the move-whisper branch July 12, 2019 12:15
dvdplm added a commit that referenced this pull request Jul 12, 2019
@dvdplm
Merge branch 'master' into dp/chore/move-more-types-out-of-ethcore
8e88f2e 
* master:
  whisper is no longer a part of parity-ethereum repo (#10855)
  [ethash] remove mem::uninitialized (#10861)
  Docker images renaming (#10863)
  Move the substate module into ethcore/executive (#10867)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dvdplm dvdplm dvdplm approved these changes

@ordian ordian ordian approved these changes

Assignees
No one assigned
Labels
A8-looksgood 🦄 Pull request is reviewed well. B7-releasenotes 📜 Changes should be mentioned in the release notes of the next minor version release. M4-core ⛓ Core client code / Rust.
Projects
None yet
Milestone
2.7
Development

Successfully merging this pull request may close these issues.
5 participants
@debris @dvdplm @ltfschoen @ordian @jam10o-new