Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

remove QueueError #10852

Merged
merged 1 commit into from
Jul 6, 2019
Merged

remove QueueError #10852

merged 1 commit into from
Jul 6, 2019

Conversation

debris
Copy link
Collaborator

@debris debris commented Jul 6, 2019 •
edited
Loading

it simplifies a bit ethcore::Error type

@debris debris added A0-pleasereview 🤓 Pull request needs code review. A2-insubstantial 👶 Pull request requires no code review (e.g., a sub-repository hash update). labels Jul 6, 2019
@debris debris requested a review from dvdplm July 6, 2019 15:26
dvdplm
dvdplm approved these changes Jul 6, 2019
View reviewed changes
Copy link
Collaborator

@dvdplm dvdplm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm although I’d probably have named it QueueFull but that’s irrelevant. :)

@ordian ordian added this to the 2.7 milestone Jul 6, 2019
@ordian ordian added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Jul 6, 2019
@ordian ordian merged commit c4c5d79 into master Jul 6, 2019
@ordian ordian deleted the remove-queue-error branch July 6, 2019 18:40
dvdplm added a commit that referenced this pull request Jul 6, 2019
@dvdplm
Merge branch 'master' into dp/chore/extricate-state-backend
e3d98b7 
* master:
  removed QueueError type (#10852)
  removed unused macros (#10851)
  bump crossbeam (#10848)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dvdplm dvdplm dvdplm approved these changes

@ordian ordian ordian approved these changes

Assignees
No one assigned
Labels
A2-insubstantial 👶 Pull request requires no code review (e.g., a sub-repository hash update). A8-looksgood 🦄 Pull request is reviewed well.
Projects
None yet
Milestone
2.7
Development

Successfully merging this pull request may close these issues.
3 participants
@debris @dvdplm @ordian