Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

When an account password file is not found and parity is run as a daemon it silently fails #9367

Closed
XertroV opened this issue Aug 17, 2018 · 0 comments
Closed

When an account password file is not found and parity is run as a daemon it silently fails #9367

XertroV opened this issue Aug 17, 2018 · 0 comments
Assignees
@seunlanlege
Labels
F3-annoyance 💩 The client behaves within expectations, however this “expected behaviour” itself is at issue. M4-core ⛓ Core client code / Rust.
Milestone
2.3

Comments

@XertroV
Copy link
Contributor

XertroV commented Aug 17, 2018

I'm running:

  • Which Parity version?: 2.0.1-beta
  • Which operating system?: Linux
  • How installed?: via binaries
  • Are you fully synchronized?: no
  • Which network are you connected to?: custom poa
  • Did you try to restart the node?: yes

To test set

[account]
password = ["/does-not-exist.txt"]

and run parity --config config.toml daemon pidfile, then run parity --config config.toml and you'll see the error.
@Tbaut Tbaut added F3-annoyance 💩 The client behaves within expectations, however this “expected behaviour” itself is at issue. M4-core ⛓ Core client code / Rust. labels Aug 17, 2018
@Tbaut Tbaut added this to the 2.1 milestone Aug 17, 2018
@5chdn 5chdn modified the milestones: 2.1, 2.2 Sep 11, 2018
@5chdn 5chdn modified the milestones: 2.2, 2.3 Oct 29, 2018
@seunlanlege seunlanlege self-assigned this Nov 19, 2018
seunlanlege added a commit that referenced this issue Nov 20, 2018
@seunlanlege
prevent silent errors in daemon mode, closes #9367
82b476b
seunlanlege added a commit that referenced this issue Nov 20, 2018
@seunlanlege
prevent silent errors in daemon mode, closes #9367
cecb038
5chdn pushed a commit that referenced this issue Nov 27, 2018
@seunlanlege @5chdn
prevent silent errors in daemon mode, closes #9367 (#9946)
87ccdae
5chdn pushed a commit that referenced this issue Nov 27, 2018
@seunlanlege @5chdn
prevent silent errors in daemon mode, closes #9367 (#9946)
56e942f
5chdn added a commit that referenced this issue Nov 28, 2018
@5chdn
Backports for stable 2.1.7 (#9975)
126208c 
* version: bump stable to 2.1.7

* Adjust requests costs for light client (#9925)

* PIP Table Cost relative to average peers instead of max peers

* Add tracing in PIP new_cost_table

* Update stat peer_count

* Use number of leeching peers for Light serve costs

* Fix test::light_params_load_share_depends_on_max_peers (wrong type)

* Remove (now) useless test

* Remove `load_share` from LightParams.Config
Prevent div. by 0

* Add LEECHER_COUNT_FACTOR

* PR Grumble: u64 to u32 for f64 casting

* Prevent u32 overflow for avg_peer_count

* Add tests for LightSync::Statistics

* Fix empty steps (#9939)

* Don't send empty step twice or empty step then block.

* Perform basic validation of locally sealed blocks.

* Don't include empty step twice.

* prevent silent errors in daemon mode, closes #9367 (#9946)

* Fix light client informant while syncing (#9932)

* Add `is_idle` to LightSync to check importing status

* Use SyncStateWrapper to make sure is_idle gets updates

* Update is_major_import to use verified queue size as well

* Add comment for `is_idle`

* Add Debug to `SyncStateWrapper`

* `fn get` -> `fn into_inner`

*  ci: rearrange pipeline by logic (#9970)

* ci: rearrange pipeline by logic

* ci: rename docs script

* Add readiness check for docker container (#9804)

* Update Dockerfile

Since parity is built for "mission critical use", I thought other operators may see the need for this.

Adding the `curl` and `jq` commands allows for an extremely simple health check to be usable in container orchestrators.

For example. Here is a health check for a parity docker container running in Kubernetes.

This can be setup as a readiness Probe that would prevent clustered nodes that aren't ready from serving traffic.

```bash
#!/bin/bash

ETH_SYNCING=$(curl -X POST --data '{"jsonrpc":"2.0","method":"eth_syncing","params":[],"id":1}' http://localhost:8545 -H 'Content-Type: application/json')
RESULT=$(echo "$ETH_SYNCING | jq -r .result)

if [ "$RESULT" == "false" ]; then
  echo "Parity is ready to start accepting traffic"
  exit 0
else
  echo "Parity is still syncing the blockchain"
  exit 1
fi
```

* add sync check script

* Fix docker script (#9854)


* Dockerfile: change source path of the newly added check_sync.sh (#9869)

* Do not use the home directory as the working dir in docker (#9834)

* Do not create a home directory.

* Re-add -m flag

* fix docker build (#9971)

* bump smallvec to 0.6 in ethcore-light, ethstore and whisper (#9588)

* bump smallvec to 0.6 in ethcore-light, ethstore and whisper

* bump transaction-pool

* Fix test.

* patch cargo to use tokio-proto from git repo

this makes sure we no longer depend on smallvec 0.2.1 which is
affected by servo/rust-smallvec#96

* use patched version of untrusted 0.5.1

* ci: allow audit to fail
5chdn added a commit that referenced this issue Nov 29, 2018
@5chdn
Backports for beta 2.2.2 (#9976)
78ceec6 
* version: bump beta to 2.2.2

* Add experimental RPCs flag (#9928)

* WiP

* Enable experimental RPCs.

* Keep existing blocks when restoring a Snapshot (#8643)

* Rename db_restore => client

* First step: make it compile!

* Second step: working implementation!

* Refactoring

* Fix tests

* PR Grumbles

* PR Grumbles WIP

* Migrate ancient blocks interating backward

* Early return in block migration if snapshot is aborted

* Remove RwLock getter (PR Grumble I)

* Remove dependency on `Client`: only used Traits

* Add test for recovering aborted snapshot recovery

* Add test for migrating old blocks

* Fix build

* PR Grumble I

* PR Grumble II

* PR Grumble III

* PR Grumble IV

* PR Grumble V

* PR Grumble VI

* Fix one test

* Fix test

* PR Grumble

* PR Grumbles

* PR Grumbles II

* Fix tests

* Release RwLock earlier

* Revert Cargo.lock

* Update _update ancient block_ logic: set local in `commit`

* Update typo in ethcore/src/snapshot/service.rs

Co-Authored-By: ngotchac <ngotchac@gmail.com>

* Adjust requests costs for light client (#9925)

* PIP Table Cost relative to average peers instead of max peers

* Add tracing in PIP new_cost_table

* Update stat peer_count

* Use number of leeching peers for Light serve costs

* Fix test::light_params_load_share_depends_on_max_peers (wrong type)

* Remove (now) useless test

* Remove `load_share` from LightParams.Config
Prevent div. by 0

* Add LEECHER_COUNT_FACTOR

* PR Grumble: u64 to u32 for f64 casting

* Prevent u32 overflow for avg_peer_count

* Add tests for LightSync::Statistics

* Fix empty steps (#9939)

* Don't send empty step twice or empty step then block.

* Perform basic validation of locally sealed blocks.

* Don't include empty step twice.

* prevent silent errors in daemon mode, closes #9367 (#9946)

* Fix a deadlock (#9952)

* Update informant:
  - decimal in Mgas/s
  - print every 5s (not randomly between 5s and 10s)

* Fix dead-lock in `blockchain.rs`

* Update locks ordering

* Fix light client informant while syncing (#9932)

* Add `is_idle` to LightSync to check importing status

* Use SyncStateWrapper to make sure is_idle gets updates

* Update is_major_import to use verified queue size as well

* Add comment for `is_idle`

* Add Debug to `SyncStateWrapper`

* `fn get` -> `fn into_inner`

*  ci: rearrange pipeline by logic (#9970)

* ci: rearrange pipeline by logic

* ci: rename docs script

* fix docker build (#9971)

* Deny unknown fields for chainspec (#9972)

* Add deny_unknown_fields to chainspec

* Add tests and fix existing one

* Remove serde_ignored dependency for chainspec

* Fix rpc test eth chain spec

* Fix starting_nonce_test spec

* Improve block and transaction propagation (#9954)

* Refactor sync to add priority tasks.

* Send priority tasks notifications.

* Propagate blocks, optimize transactions.

* Implement transaction propagation. Use sync_channel.

* Tone down info.

* Prevent deadlock by not waiting forever for sync lock.

* Fix lock order.

* Don't use sync_channel to prevent deadlocks.

* Fix tests.

* Fix unstable peers and slowness in sync (#9967)

* Don't sync all peers after each response

* Update formating

* Fix tests: add `continue_sync` to `Sync_step`

* Update ethcore/sync/src/chain/mod.rs

Co-Authored-By: ngotchac <ngotchac@gmail.com>

* fix rpc middlewares

* fix Cargo.lock

* json: resolve merge in spec

* rpc: fix starting_nonce_test

* ci: allow nightl job to fail
ordian added a commit that referenced this issue Nov 30, 2018
@ordian
Revert "prevent silent errors in daemon mode, closes #9367 (#9946)"
e74903f 
This reverts commit 52d5278.
@ordian ordian mentioned this issue Nov 30, 2018
Merged
5chdn pushed a commit that referenced this issue Nov 30, 2018
@ordian @5chdn
Fix daemonize (#10000)
7000c39 
* Revert "prevent silent errors in daemon mode, closes #9367 (#9946)"

This reverts commit 52d5278.

* deps(daemonize): switch back to crates.io
@ordian ordian mentioned this issue Nov 30, 2018
Merged
5chdn pushed a commit that referenced this issue Nov 30, 2018
@ordian @5chdn
Fix daemonize (#10000)
4138960 
* Revert "prevent silent errors in daemon mode, closes #9367 (#9946)"

This reverts commit 52d5278.

* deps(daemonize): switch back to crates.io
5chdn pushed a commit that referenced this issue Nov 30, 2018
@ordian @5chdn
Fix daemonize (#10000)
815037b 
* Revert "prevent silent errors in daemon mode, closes #9367 (#9946)"

This reverts commit 52d5278.

* deps(daemonize): switch back to crates.io
5chdn added a commit that referenced this issue Nov 30, 2018
@5chdn
Stable patch release 2.1.8 (#10001)
3eae1d3 
* version: bump stable to 2.1.8

* Fix Bloom migration (#9992)

* Fix wrong block number in blooms migration

* Fix wrong `const` type (usize -> u64) 😬

* Fix daemonize (#10000)

* Revert "prevent silent errors in daemon mode, closes #9367 (#9946)"

This reverts commit 52d5278.

* deps(daemonize): switch back to crates.io

* move daemonize before creating account provider (#10003)

* move daemonize before creating account provider

* daemonize: add a future-proofing comment
5chdn added a commit that referenced this issue Nov 30, 2018
@5chdn
Beta patch release 2.2.3 (#10002)
6b0a280 
* version: bump beta to 2.2.3

* Fix Bloom migration (#9992)

* Fix wrong block number in blooms migration

* Fix wrong `const` type (usize -> u64) 😬

* Fix daemonize (#10000)

* Revert "prevent silent errors in daemon mode, closes #9367 (#9946)"

This reverts commit 52d5278.

* deps(daemonize): switch back to crates.io

* move daemonize before creating account provider (#10003)

* move daemonize before creating account provider

* daemonize: add a future-proofing comment
niklasad1 pushed a commit that referenced this issue Dec 16, 2018
@ordian @niklasad1
Fix daemonize (#10000)
92c8709 
* Revert "prevent silent errors in daemon mode, closes #9367 (#9946)"

This reverts commit 52d5278.

* deps(daemonize): switch back to crates.io
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@seunlanlege seunlanlege

Labels
F3-annoyance 💩 The client behaves within expectations, however this “expected behaviour” itself is at issue. M4-core ⛓ Core client code / Rust.
Projects
None yet
Milestone
2.3
Development

No branches or pull requests
4 participants
@XertroV @5chdn @seunlanlege @Tbaut