use debug_struct to print trie

[debris]

discussion: #8166 (comment)

[gnunicorn]

@debris just to be clear, what we want to do here:

1. switch all debug statements to pretty-printing with {:#}
2. add debug_struct formatters where missing

Correct?

I am a bit unclear what should happen to the writeln and what it should be replaced with. Do you meant replacing it with println!? Arent' writeln! and println! using the same formatter (internally), thus {:#} is also supported with writeln?

[debris]

hi @gnunicorn .

1. yes
2. I want entire trie to be formatted only with debug_struct. The is no need to use writeln! or println! inside fmt function at all

[gnunicorn]

Implementation of 2 available in #8697.

Re 1: having removed all writeln in the fmt functions (and replaced them with fmt::Debug impl for ::Node), I am not sure where anyone intends to debug the entire TrieDB object and a quick grep didn't really yield good results -- the internal trace!-calls go to internal objects rather than the actual tree as implemented in fmt::Debug. I happily update that, too, if someone points me to the lines we actually debug-print TrieDB ...

However, it is possible with that patch to use {:#} on TrieDB :) .