This repository was archived by the owner on May 24, 2022. It is now read-only.
fix: Use preload script as proxy for main-renderer communication#518
Merged
axelchalon merged 10 commits intomasterfrom May 7, 2019
Merged
fix: Use preload script as proxy for main-renderer communication#518axelchalon merged 10 commits intomasterfrom
axelchalon merged 10 commits intomasterfrom
Conversation
Collaborator
Author
|
I tested (in both yarn electron and yarn start):
|
amaury1093
commented
May 6, 2019
| wsPort: remote.getGlobal('wsPort') | ||
| }; | ||
| const RENDERER_ORIGIN = | ||
| remote.getGlobal('IS_PROD') === true ? 'file://' : 'http://localhost:3000'; |
Collaborator
Author
There was a problem hiding this comment.
If someone has an idea how not to hardcode these origins, I'm all ears
| manifest-src 'none'; | ||
| media-src 'none'; | ||
| object-src 'none'; | ||
| prefetch-src 'none'; |
Collaborator
Author
There was a problem hiding this comment.
prefetch-src gave me a "unknown csp" warning, so I removed it
| block-all-mixed-content; | ||
| child-src 'none'; | ||
| connect-src https: ws:; | ||
| connect-src 'self' https: ws:; |
Collaborator
Author
There was a problem hiding this comment.
@yjkimjunior I needed to add 'self', or else yarn start didn't work
Tbaut
approved these changes
May 7, 2019
Collaborator
Tbaut
left a comment
There was a problem hiding this comment.
I could send a Tx on Kovan without problem. Switched language as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #497
Also:
isParityRunningeverywhere, as we're not using it at allAll messages between main and renderer have the following format: