libvpx: remove explicit armv5 and armv6 support #764
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shr-project
reviewed
Nov 18, 2023
| @@ -24,8 +24,6 @@ BUILD_LDFLAGS += "-pthread" | |||
| export CC | |||
| export LD = "${CC}" | |||
|
|
|||
| VPXTARGET:armv5te = "armv5te-linux-gcc" | |||
| VPXTARGET:armv6 = "armv6-linux-gcc" | |||
There was a problem hiding this comment.
if it doesn't build anymore, can you add COMPATIBLE_HOST restriction to indicate that?
There was a problem hiding this comment.
Sorry, wasn't completely precise. The recipe fails to build for these targets in case the VPXTARGET variable is set to the specific toolchain name. In case the fallthrough generic-gnu value is used (like it is used for the other arch's), the recipe still builds.
There was a problem hiding this comment.
OK, then please update the commit message in the commit itself which currently has only the summary (not PR description) to make it more clear.
There was a problem hiding this comment.
Sure, done.
OldManYellsAtCloud
changed the title
shr-project
requested changes
Nov 18, 2023
| @@ -24,8 +24,6 @@ BUILD_LDFLAGS += "-pthread" | |||
| export CC | |||
| export LD = "${CC}" | |||
|
|
|||
| VPXTARGET:armv5te = "armv5te-linux-gcc" | |||
| VPXTARGET:armv6 = "armv6-linux-gcc" | |||
There was a problem hiding this comment.
OK, then please update the commit message in the commit itself which currently has only the summary (not PR description) to make it more clear.
The libvpx project has removed the support for these values, and the recipe can't be built anymore for these arch's when these values are used. The correct value for these arch's is `generic-gnu`, which is used as a default fallthrough value for all platforms in the recipe for arch's that are not specified explicitly.
|
applied with 82d0508 |
dylan-matthew-turner
pushed a commit
to dylan-matthew-turner/meta-openembedded
that referenced
this pull request
Dec 6, 2023
This release contains bug fixes only. The following CVEs have been addressed: CVE-2023-27783 CVE-2023-27784 CVE-2023-27785 CVE-2023-27786 CVE-2023-27787 CVE-2023-27788 CVE-2023-27789 Changelog: ========= dlt_jnpr_ether_cleanup: check subctx before cleanup by @Marsman1996 in openembedded#781 Bug openembedded#780 assert tcpedit dlt cleanup by @fklassen in openembedded#800 Fix bugs caused by strtok_r by @Marsman1996 in openembedded#783 Bug openembedded#782 openembedded#784 openembedded#785 openembedded#786 openembedded#787 openembedded#788 strtok r isuses by @fklassen in openembedded#801 Update en10mb.c by @david-guti in openembedded#793 PR openembedded#793 ip6 unicast flood by @fklassen in openembedded#802 Bug openembedded#719 fix overflow check for parse_mpls() by @fklassen in openembedded#804 PR openembedded#793 - update tests for corrected IPv6 MAC by @fklassen in openembedded#805 PR openembedded#793 - update tests for vlandel by @fklassen in openembedded#806 Feature openembedded#773 gh actions ci by @fklassen in openembedded#807 Feature openembedded#759: Upgrade autogen/libopts to 5.18.16 by @fklassen in openembedded#760 Bug openembedded#751 don't exit after send error by @fklassen in openembedded#761 Bug openembedded#750: configure: libpcap version robustness by @fklassen in openembedded#764 Bug openembedded#749 flow stats: avoid overstating flow packet count by @fklassen in openembedded#765 Bug openembedded#750 more libpcap version updates by @fklassen in openembedded#766 Bug openembedded#767 tests: support for out-of-tree tests by @fklassen in openembedded#768 Bug openembedded#750 - fix macOS test failure by @fklassen in openembedded#770 4.4.3 by @fklassen in openembedded#769 and openembedded#771 Signed-off-by: Archana Polampalli <archana.polampalli@windriver.com> Signed-off-by: Armin Kuster <akuster808@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove armv6 and armv5 targets from libvpx recipe, they don't build anymore (in case the toolchain name is specified) - the upstream project has dropped armv6 it in 2016 and armv5 in 2014.
The recipe builds in case the fallthrough
generic-gnuvalue is used.