-
Notifications
You must be signed in to change notification settings - Fork 710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Meta python merge #480
Closed
Closed
Meta python merge #480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3.1.3 ===== rename `aenum.property` to `aenum.enum_property` (`aenum.property still exists, but was too easily confused with the built-in property) fix `enum_property` to work with `_init_` attributes Signed-off-by: Wang Mingyu <wangmy@fujitsu.com> Signed-off-by: Khem Raj <raj.khem@gmail.com> Signed-off-by: Trevor Gamblin <trevor.gamblin@windriver.com>
License-Update: Description of license is replaced by website "http://www.apache.org/licenses/LICENSE-2.0" Signed-off-by: Wang Mingyu <wangmy@fujitsu.com> Signed-off-by: Khem Raj <raj.khem@gmail.com> Signed-off-by: Trevor Gamblin <trevor.gamblin@windriver.com>
License-Update: Description of license is replaced by website "http://www.apache.org/licenses/LICENSE-2.0" Signed-off-by: Wang Mingyu <wangmy@fujitsu.com> Signed-off-by: Khem Raj <raj.khem@gmail.com> Signed-off-by: Trevor Gamblin <trevor.gamblin@windriver.com>
Signed-off-by: Wang Mingyu <wangmy@fujitsu.com> Signed-off-by: Khem Raj <raj.khem@gmail.com> Signed-off-by: Trevor Gamblin <trevor.gamblin@windriver.com>
Features androidmanagement: update the api be2e5dd (5dcb723) appengine: update the api 4535ce5 (5dcb723) artifactregistry: update the api 882fdb3 (5dcb723) chromepolicy: update the api c330a6f (5dcb723) cloudidentity: update the api d0f0527 (5dcb723) composer: update the api 2bfa5a1 (5dcb723) compute: update the api b917688 (5dcb723) datastream: update the api 218521c (5dcb723) dns: update the api 540233d (5dcb723) healthcare: update the api 1e029c8 (5dcb723) ondemandscanning: update the api 9f998b4 (5dcb723) osconfig: update the api 59cea85 (5dcb723) paymentsresellersubscription: update the api efb5b4f (5dcb723) privateca: update the api b4ae2c8 (5dcb723) recommender: update the api 8dffae4 (5dcb723) retail: update the api f711074 (5dcb723) storagetransfer: update the api c835926 (5dcb723) streetviewpublish: update the api 35f0b1b (5dcb723) translate: update the api 1f848a5 (5dcb723) Signed-off-by: Wang Mingyu <wangmy@fujitsu.com> Signed-off-by: Khem Raj <raj.khem@gmail.com> Signed-off-by: Trevor Gamblin <trevor.gamblin@windriver.com>
Changelog Version 0.18 Change of beaviour: File endings are now normalized so that all DOT source outputs end with a final newline (Unix convention, simplifies concatenation). This includes DOT source files written by .render(), .view(), or .save() as well was .source generated or loaded from Source (or Source.from_file()). Change of behaviour: Source instances created by Source.from_file() no nonger write the content read into .source back into the file. Use .save(skip_existing=False) before calling .render() or .view() if you want to overwrite the file to produce the previous (less safe) behaviour. Change of undocumented behaviour: When iterating over a Graph, Digraph, or Source instance, the yielded lines now include a final newline ('\n'). This mimics iteration over file object lines in text mode. When passing invalid parameters such as unknown engine, format, etc., .render() now raises early before writing the file. Call .save() explicitly to produce the previous (less safe) behaiour. Add optional keyword-only encoding argument to pipe(). Returns the decoded stdout from the rendering process (e.g. format='svg'). Delegates encoding/decoding to subprocess in the common case (input and output encoding are the same, e.g. default encoding='utf-8'). Used by the Jupyter notebook integration. Add optional keyword-only engine argument to .pipe() and .render(). Add optional keyword-only renderer and formatter arguments to Graph(), Digraph(), Source() and Source.from_file() to set default renderers and formatters (similar to format). Used by .pipe(), .render(), and .view() if not given as method-argument. Add pipe_string(), pipe_lines(), and pipe_lines_string(). Pipe input_string, return string. Pipe input_lines incrementally, return bytes. Pipe input_lines incrementally, return string. Add set_default_engine() and set_default_format() Add backend.DOT_BINARY and backend.UNFLATTEN_BINARY. Restructure the internal class hierarchy using multiple-inheritance with cooperative super() calling: Graph now inherits both from Dot and from Render, and both of them inherit from Base which defines their common interface: Lines of DOT source code that Dot generates (also Source) and rendering iterates over. This might break some undocumented use of subclassing and require adatation Improve test separation. Improve test coverage of running the tests with --skip-exe. Add pytype checking and flake8 to build workflow. Extend type annotations. Add https://mybinder.org config with head development environment. Add launch badge to code repository. Improve documentation and examples. Add development docs. Document release process. Signed-off-by: Wang Mingyu <wangmy@fujitsu.com> Signed-off-by: Khem Raj <raj.khem@gmail.com> Signed-off-by: Trevor Gamblin <trevor.gamblin@windriver.com>
0.20.2 auth: support pyparsing v3 (AttributeError downcaseTokens) httplib2/httplib2#207 proxy: correct extraction of errno from pysocks ProxyConnectionError httplib2/httplib2#202 Signed-off-by: Wang Mingyu <wangmy@fujitsu.com> Signed-off-by: Khem Raj <raj.khem@gmail.com> Signed-off-by: Trevor Gamblin <trevor.gamblin@windriver.com>
Upgrade to release 5.1.0: - Synced with Python 3.10.0. - Packaging refresh. - Tests now run on Python 3.10. - Modernized code relying on Python 3.6. Signed-off-by: Leon Anavi <leon.anavi@konsulko.com> Signed-off-by: Khem Raj <raj.khem@gmail.com> Signed-off-by: Trevor Gamblin <trevor.gamblin@windriver.com>
this is merged. |
kraj
pushed a commit
to YoeDistro/meta-openembedded
that referenced
this pull request
May 8, 2023
Changelog: ========= Add support for PySide6: openembedded#487 Add missing 'priority' argument for GLib.to_add_watch() openembedded#479 Tidies and Maintenance: openembedded#486 openembedded#485 openembedded#484 openembedded#481 openembedded#480 openembedded#477 openembedded#474 Signed-off-by: Wang Mingyu <wangmy@fujitsu.com> Signed-off-by: Khem Raj <raj.khem@gmail.com>
kraj
pushed a commit
to YoeDistro/meta-openembedded
that referenced
this pull request
May 8, 2023
Changelog: ========= Add support for PySide6: openembedded#487 Add missing 'priority' argument for GLib.to_add_watch() openembedded#479 Tidies and Maintenance: openembedded#486 openembedded#485 openembedded#484 openembedded#481 openembedded#480 openembedded#477 openembedded#474 Signed-off-by: Wang Mingyu <wangmy@fujitsu.com> Signed-off-by: Khem Raj <raj.khem@gmail.com>
kraj
pushed a commit
to YoeDistro/meta-openembedded
that referenced
this pull request
May 9, 2023
Changelog: ========= Add support for PySide6: openembedded#487 Add missing 'priority' argument for GLib.to_add_watch() openembedded#479 Tidies and Maintenance: openembedded#486 openembedded#485 openembedded#484 openembedded#481 openembedded#480 openembedded#477 openembedded#474 Signed-off-by: Wang Mingyu <wangmy@fujitsu.com> Signed-off-by: Khem Raj <raj.khem@gmail.com>
kraj
pushed a commit
to YoeDistro/meta-openembedded
that referenced
this pull request
May 9, 2023
Changelog: ========= Add support for PySide6: openembedded#487 Add missing 'priority' argument for GLib.to_add_watch() openembedded#479 Tidies and Maintenance: openembedded#486 openembedded#485 openembedded#484 openembedded#481 openembedded#480 openembedded#477 openembedded#474 Signed-off-by: Wang Mingyu <wangmy@fujitsu.com> Signed-off-by: Khem Raj <raj.khem@gmail.com>
kraj
pushed a commit
to YoeDistro/meta-openembedded
that referenced
this pull request
May 9, 2023
Changelog: ========= Add support for PySide6: openembedded#487 Add missing 'priority' argument for GLib.to_add_watch() openembedded#479 Tidies and Maintenance: openembedded#486 openembedded#485 openembedded#484 openembedded#481 openembedded#480 openembedded#477 openembedded#474 Signed-off-by: Wang Mingyu <wangmy@fujitsu.com> Signed-off-by: Khem Raj <raj.khem@gmail.com>
kraj
pushed a commit
to YoeDistro/meta-openembedded
that referenced
this pull request
Jun 13, 2023
Changelog: =========== lib: Fix some small bugs spotted by newest covscan (openembedded#471) ipc: Retry receiving credentials if the the message is short (openembedded#476) timer: Move state check to before time check (openembedded#479) tests: Close race condition in check_loop (openembedded#480) blackbox: fix potential overlow/memory corruption (openembedded#486) tests: Make ipc test more portable (openembedded#466) tests: cleanup the last of the empty directories (openembedded#467) doxygen2man: Fix function parameter alignment (openembedded#468) tests: Fix tests on FreeBSD-devel (openembedded#469) test: Remove gnu/lib-names.h from libstat_wrapper.c (openembedded#482) tests: allow -j to work (openembedded#485) Update -version info for 2.0.7 Add --disable-tests option (openembedded#475) configure: Modernize configure.ac a bit (openembedded#470) spec: Migrate to SPDX license (openembedded#487) add simplified chinese readme (openembedded#474) m4/ax_pthread.m4: update to latest upstream version (serial 31) (openembedded#472) strlcpy: avoid compiler warning from strncpy (openembedded#473) Signed-off-by: Wang Mingyu <wangmy@fujitsu.com> Signed-off-by: Khem Raj <raj.khem@gmail.com>
kraj
pushed a commit
to YoeDistro/meta-openembedded
that referenced
this pull request
Jun 14, 2023
Changelog: =========== lib: Fix some small bugs spotted by newest covscan (openembedded#471) ipc: Retry receiving credentials if the the message is short (openembedded#476) timer: Move state check to before time check (openembedded#479) tests: Close race condition in check_loop (openembedded#480) blackbox: fix potential overlow/memory corruption (openembedded#486) tests: Make ipc test more portable (openembedded#466) tests: cleanup the last of the empty directories (openembedded#467) doxygen2man: Fix function parameter alignment (openembedded#468) tests: Fix tests on FreeBSD-devel (openembedded#469) test: Remove gnu/lib-names.h from libstat_wrapper.c (openembedded#482) tests: allow -j to work (openembedded#485) Update -version info for 2.0.7 Add --disable-tests option (openembedded#475) configure: Modernize configure.ac a bit (openembedded#470) spec: Migrate to SPDX license (openembedded#487) add simplified chinese readme (openembedded#474) m4/ax_pthread.m4: update to latest upstream version (serial 31) (openembedded#472) strlcpy: avoid compiler warning from strncpy (openembedded#473) Signed-off-by: Wang Mingyu <wangmy@fujitsu.com> Signed-off-by: Khem Raj <raj.khem@gmail.com>
kraj
pushed a commit
to YoeDistro/meta-openembedded
that referenced
this pull request
Aug 17, 2023
…27995b38eb4271044f) Drop patches now part of new upstream release: - 449.patch - 481.patch - 482.patch Refresh patches due to GENIVI->COVESA renaming What's Changed: Update ReleaseNotes and version to v2.18.9 by @minminlittleshrimp in openembedded#468 Update status badges on README.md by @michael-methner in openembedded#467 logstorage: Adds option to write logs in gzip format by @LiquidityC in openembedded#442 Re-Initialize internal logging in daemon mode only by @lvklevankhanh in openembedded#459 Remove use of DLT_LOG in signal handler by @michael-methner in openembedded#472 Update gtest_dlt_daemon_multiple_files_logging.cpp by @LocutusOfBorg in openembedded#481 Update AUTOSAR standard link by @lucafrance in openembedded#480 cmake: set version to 2.18.9 by @alexmohr in openembedded#478 Fix macro code to use boolean value in while instruction (false) by @michael-methner in openembedded#469 dlt_user_shared: Add timeout to writev by @alexmohr in openembedded#385 build: add static lib only if necessary by @alexmohr in openembedded#479 Update CMakeLists.txt by @LocutusOfBorg in openembedded#482 watchdog: improve dlt watchdog by @alexmohr in openembedded#470 log-level-config: add option to configure log levels by @alexmohr in openembedded#474 gtest_dlt_daemon_gateway: dlt-daemon run without dlt_passive.conf file by @lti9hc in openembedded#487 dlt_unit_test: Fix and improve quality of unit tests by @minminlittleshrimp in openembedded#494 dlt-qnx-system improvement by @lvklevankhanh in openembedded#495 gtest: Init submodule and update version by @minminlittleshrimp in openembedded#497 dlt-qnx-system: prevent message loss in high load situations by @alexmohr in openembedded#490 Fix compile error stringop-truncation with GCC 9.4 by @michael-methner in openembedded#499 Update README.md by @lvklevankhanh in openembedded#503 dlt-coverage: Add coverage report generator for dlt by @minminlittleshrimp in openembedded#501 dlt-system: move journal reading to its own thread by @alexmohr in openembedded#471 Switch from GENIVI to COVESA by @minminlittleshrimp in openembedded#511 Update CMakeLists.txt: set required std version to gnu++14 by @LocutusOfBorg in openembedded#504 cmake: Policy CMP0115 set to OLD behavior for dlt-daemon with cmake >= 3.20 by @minminlittleshrimp in openembedded#510 fix usage of pthread_cond_timedwait by @alexmohr in openembedded#491 DLT Upstream for minor release by @minminlittleshrimp in openembedded#515 cmake: disable network trace by @alexmohr in openembedded#477 doc: add COVESA logo image by @minminlittleshrimp in openembedded#516 Prepare for 2.18.10 release by @michael-methner in openembedded#517 Signed-off-by: Gianfranco Costamagna <costamagnagianfranco@yahoo.it> Signed-off-by: Gianfranco Costamagna <locutusofborg@debian.org> Signed-off-by: Khem Raj <raj.khem@gmail.com>
kraj
pushed a commit
to YoeDistro/meta-openembedded
that referenced
this pull request
Aug 17, 2023
…27995b38eb4271044f) Drop patches now part of new upstream release: - 449.patch - 481.patch - 482.patch Refresh patches due to GENIVI->COVESA renaming What's Changed: Update ReleaseNotes and version to v2.18.9 by @minminlittleshrimp in openembedded#468 Update status badges on README.md by @michael-methner in openembedded#467 logstorage: Adds option to write logs in gzip format by @LiquidityC in openembedded#442 Re-Initialize internal logging in daemon mode only by @lvklevankhanh in openembedded#459 Remove use of DLT_LOG in signal handler by @michael-methner in openembedded#472 Update gtest_dlt_daemon_multiple_files_logging.cpp by @LocutusOfBorg in openembedded#481 Update AUTOSAR standard link by @lucafrance in openembedded#480 cmake: set version to 2.18.9 by @alexmohr in openembedded#478 Fix macro code to use boolean value in while instruction (false) by @michael-methner in openembedded#469 dlt_user_shared: Add timeout to writev by @alexmohr in openembedded#385 build: add static lib only if necessary by @alexmohr in openembedded#479 Update CMakeLists.txt by @LocutusOfBorg in openembedded#482 watchdog: improve dlt watchdog by @alexmohr in openembedded#470 log-level-config: add option to configure log levels by @alexmohr in openembedded#474 gtest_dlt_daemon_gateway: dlt-daemon run without dlt_passive.conf file by @lti9hc in openembedded#487 dlt_unit_test: Fix and improve quality of unit tests by @minminlittleshrimp in openembedded#494 dlt-qnx-system improvement by @lvklevankhanh in openembedded#495 gtest: Init submodule and update version by @minminlittleshrimp in openembedded#497 dlt-qnx-system: prevent message loss in high load situations by @alexmohr in openembedded#490 Fix compile error stringop-truncation with GCC 9.4 by @michael-methner in openembedded#499 Update README.md by @lvklevankhanh in openembedded#503 dlt-coverage: Add coverage report generator for dlt by @minminlittleshrimp in openembedded#501 dlt-system: move journal reading to its own thread by @alexmohr in openembedded#471 Switch from GENIVI to COVESA by @minminlittleshrimp in openembedded#511 Update CMakeLists.txt: set required std version to gnu++14 by @LocutusOfBorg in openembedded#504 cmake: Policy CMP0115 set to OLD behavior for dlt-daemon with cmake >= 3.20 by @minminlittleshrimp in openembedded#510 fix usage of pthread_cond_timedwait by @alexmohr in openembedded#491 DLT Upstream for minor release by @minminlittleshrimp in openembedded#515 cmake: disable network trace by @alexmohr in openembedded#477 doc: add COVESA logo image by @minminlittleshrimp in openembedded#516 Prepare for 2.18.10 release by @michael-methner in openembedded#517 Signed-off-by: Gianfranco Costamagna <costamagnagianfranco@yahoo.it> Signed-off-by: Gianfranco Costamagna <locutusofborg@debian.org> Signed-off-by: Khem Raj <raj.khem@gmail.com>
kraj
pushed a commit
to YoeDistro/meta-openembedded
that referenced
this pull request
Aug 17, 2023
…27995b38eb4271044f) Drop patches now part of new upstream release: - 449.patch - 481.patch - 482.patch Refresh patches due to GENIVI->COVESA renaming What's Changed: Update ReleaseNotes and version to v2.18.9 by @minminlittleshrimp in openembedded#468 Update status badges on README.md by @michael-methner in openembedded#467 logstorage: Adds option to write logs in gzip format by @LiquidityC in openembedded#442 Re-Initialize internal logging in daemon mode only by @lvklevankhanh in openembedded#459 Remove use of DLT_LOG in signal handler by @michael-methner in openembedded#472 Update gtest_dlt_daemon_multiple_files_logging.cpp by @LocutusOfBorg in openembedded#481 Update AUTOSAR standard link by @lucafrance in openembedded#480 cmake: set version to 2.18.9 by @alexmohr in openembedded#478 Fix macro code to use boolean value in while instruction (false) by @michael-methner in openembedded#469 dlt_user_shared: Add timeout to writev by @alexmohr in openembedded#385 build: add static lib only if necessary by @alexmohr in openembedded#479 Update CMakeLists.txt by @LocutusOfBorg in openembedded#482 watchdog: improve dlt watchdog by @alexmohr in openembedded#470 log-level-config: add option to configure log levels by @alexmohr in openembedded#474 gtest_dlt_daemon_gateway: dlt-daemon run without dlt_passive.conf file by @lti9hc in openembedded#487 dlt_unit_test: Fix and improve quality of unit tests by @minminlittleshrimp in openembedded#494 dlt-qnx-system improvement by @lvklevankhanh in openembedded#495 gtest: Init submodule and update version by @minminlittleshrimp in openembedded#497 dlt-qnx-system: prevent message loss in high load situations by @alexmohr in openembedded#490 Fix compile error stringop-truncation with GCC 9.4 by @michael-methner in openembedded#499 Update README.md by @lvklevankhanh in openembedded#503 dlt-coverage: Add coverage report generator for dlt by @minminlittleshrimp in openembedded#501 dlt-system: move journal reading to its own thread by @alexmohr in openembedded#471 Switch from GENIVI to COVESA by @minminlittleshrimp in openembedded#511 Update CMakeLists.txt: set required std version to gnu++14 by @LocutusOfBorg in openembedded#504 cmake: Policy CMP0115 set to OLD behavior for dlt-daemon with cmake >= 3.20 by @minminlittleshrimp in openembedded#510 fix usage of pthread_cond_timedwait by @alexmohr in openembedded#491 DLT Upstream for minor release by @minminlittleshrimp in openembedded#515 cmake: disable network trace by @alexmohr in openembedded#477 doc: add COVESA logo image by @minminlittleshrimp in openembedded#516 Prepare for 2.18.10 release by @michael-methner in openembedded#517 Signed-off-by: Gianfranco Costamagna <costamagnagianfranco@yahoo.it> Signed-off-by: Gianfranco Costamagna <locutusofborg@debian.org> Signed-off-by: Khem Raj <raj.khem@gmail.com>
halstead
pushed a commit
that referenced
this pull request
Aug 30, 2023
The delta between 2.0.6 and 2.0.8 contains the CVE-2023-39976 fix and other bugfixes. git log --oneline shows: 002171b (HEAD, tag: v2.0.8, origin/main, origin/HEAD, main) Update library version for 2.0.8 1bbaa92 log: fix potential overflow with long log messages (#490) 92ddd7c test - fix test dependancies (#489) 06c8641 (tag: v2.0.7) Update -version info for 2.0.7 0665086 spec: Migrate to SPDX license (#487) 5862acb blackbox: fix potential overlow/memory corruption (#486) a3aedbc tests: allow -j to work (#485) 335dbb6 test: Remove gnu/lib-names.h from libstat_wrapper.c (#482) 4dcdfe9 strlcpy: avoid compiler warning from strncpy (#473) 1a32a60 Add --disable-tests option (#475) 10b0623 m4/ax_pthread.m4: update to latest upstream version (serial 31) (#472) e038f59 tests: Close race condition in check_loop (#480) fde729e timer: Move state check to before time check (#479) 5594d37 ipc: Retry receiving credentials if the the message is short (#476) e8129a3 add simplified chinese readme (#474) eaa95ec lib: Fix some small bugs spotted by newest covscan (#471) 14507d5 configure: Modernize configure.ac a bit (#470) 8325d84 tests: Fix tests on FreeBSD-devel (#469) e407874 doxygen2man: Fix function parameter alignment (#468) 0eb0991 tests: cleanup the last of the empty directories (#467) 44a4cb2 tests: Make ipc test more portable (#466) 758044b (tag: v2.0.6) test: Include ipc_sock.test in the libqb-tests rpm (#463) Release Notes: https://github.com/ClusterLabs/libqb/releases Signed-off-by: Narpat Mali <narpat.mali@windriver.com> Signed-off-by: Armin Kuster <akuster808@gmail.com>
jpuhlman
pushed a commit
to MontaVista-OpenSourceTechnology/meta-openembedded
that referenced
this pull request
Sep 12, 2023
Source: meta-openembedded MR: 127624 Type: Integration Disposition: Merged from meta-openembedded ChangeID: dee7706 Description: The delta between 2.0.6 and 2.0.8 contains the CVE-2023-39976 fix and other bugfixes. git log --oneline shows: 002171b (HEAD, tag: v2.0.8, origin/main, origin/HEAD, main) Update library version for 2.0.8 1bbaa92 log: fix potential overflow with long log messages (openembedded#490) 92ddd7c test - fix test dependancies (openembedded#489) 06c8641 (tag: v2.0.7) Update -version info for 2.0.7 0665086 spec: Migrate to SPDX license (openembedded#487) 5862acb blackbox: fix potential overlow/memory corruption (openembedded#486) a3aedbc tests: allow -j to work (openembedded#485) 335dbb6 test: Remove gnu/lib-names.h from libstat_wrapper.c (openembedded#482) 4dcdfe9 strlcpy: avoid compiler warning from strncpy (openembedded#473) 1a32a60 Add --disable-tests option (openembedded#475) 10b0623 m4/ax_pthread.m4: update to latest upstream version (serial 31) (openembedded#472) e038f59 tests: Close race condition in check_loop (openembedded#480) fde729e timer: Move state check to before time check (openembedded#479) 5594d37 ipc: Retry receiving credentials if the the message is short (openembedded#476) e8129a3 add simplified chinese readme (openembedded#474) eaa95ec lib: Fix some small bugs spotted by newest covscan (openembedded#471) 14507d5 configure: Modernize configure.ac a bit (openembedded#470) 8325d84 tests: Fix tests on FreeBSD-devel (openembedded#469) e407874 doxygen2man: Fix function parameter alignment (openembedded#468) 0eb0991 tests: cleanup the last of the empty directories (openembedded#467) 44a4cb2 tests: Make ipc test more portable (openembedded#466) 758044b (tag: v2.0.6) test: Include ipc_sock.test in the libqb-tests rpm (openembedded#463) Release Notes: https://github.com/ClusterLabs/libqb/releases Signed-off-by: Narpat Mali <narpat.mali@windriver.com> Signed-off-by: Armin Kuster <akuster808@gmail.com> Signed-off-by: Jeremy A. Puhlman <jpuhlman@mvista.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.