Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

save simbev metadata #978

Merged
merged 13 commits into from
Oct 31, 2022
Merged

save simbev metadata #978

merged 13 commits into from
Oct 31, 2022

Conversation

khelfen
Copy link
Contributor

@khelfen khelfen commented Oct 17, 2022 •
edited by nesnoj
Loading

Fixes # .

Before merging into dev-branch, please make sure that

  • the CHANGELOG.rst was updated.
  • new and adjusted code is formated using black and isort.
  • the Dataset-version is updated when existing datasets are adjusted.
  • the branch was merged into the
    continuous-integration/run-everything-over-the-weekend-branch.
  • the workflow is running successful in test mode.
  • the workflow is running successful in Everything mode.

@khelfen khelfen added the 🚀 feature New feature or feature request label Oct 17, 2022
@khelfen khelfen requested a review from nesnoj October 17, 2022 07:49
@khelfen khelfen self-assigned this Oct 17, 2022
nesnoj
nesnoj requested changes Oct 27, 2022
View reviewed changes
Copy link
Member

@nesnoj nesnoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The writing should be moved, see code comments.
Are you ok with doing this?

src/egon/data/datasets/emobility/motorized_individual_travel/__init__.py Show resolved Hide resolved
src/egon/data/datasets/emobility/motorized_individual_travel/model_timeseries.py Outdated Show resolved Hide resolved
src/egon/data/datasets/emobility/motorized_individual_travel/model_timeseries.py Outdated Show resolved Hide resolved
@khelfen khelfen requested a review from nesnoj October 31, 2022 07:54
nesnoj
nesnoj approved these changes Oct 31, 2022
View reviewed changes
Copy link
Member

@nesnoj nesnoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes!
I quickly change the mentioned task order and then it's all good - gimme 1 minute.
I don not see why it wouldn't work for DE, to my mind you can simply merge it. The earlier, the better.

src/egon/data/datasets/emobility/motorized_individual_travel/__init__.py Outdated Show resolved Hide resolved
@khelfen khelfen merged commit a48f9ec into dev Oct 31, 2022
@khelfen khelfen deleted the feature/simbev-metadata branch October 31, 2022 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nesnoj nesnoj nesnoj approved these changes

Assignees

@khelfen khelfen

Labels
🚀 feature New feature or feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@khelfen @nesnoj