Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes/#776 missing egon100 re power plants and reservoir run of river #808

Closed
wants to merge 4 commits into from
Closed

Fixes/#776 missing egon100 re power plants and reservoir run of river #808

wants to merge 4 commits into from

Conversation

CarlosEpia
Copy link
Contributor

@CarlosEpia CarlosEpia commented Jun 14, 2022 •
edited by ClaraBuettner
Loading

Fixes #798 and #776.

Before merging into dev-branch, please make sure that

  • the CHANGELOG.rst was updated.
  • new and adjusted code is formated using black and isort.
  • the Dataset-version is updated when existing datasets are adjusted.
  • the branch was merged into the
    continuous-integration/run-everything-over-the-weekend-branch.
  • the workflow is running successful in test mode.
  • the workflow is running successful in Everything mode.

ClaraBuettner
ClaraBuettner approved these changes Jun 22, 2022
View reviewed changes
Copy link
Contributor

@ClaraBuettner ClaraBuettner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The adjusted functions run successfully on CI-branch. The code looks fine, I just had a verry small comment, so I approve this.

@CarlosEpia
Copy link
Contributor Author

The results in grid.egon_etrago_generator look like expected. I proceed to merge this branch into dev.

@CarlosEpia CarlosEpia closed this Jun 23, 2022
@CarlosEpia CarlosEpia deleted the fixes/#776-missing-egon100RE-power-plants-and-reservoir-run_of_river branch June 23, 2022 07:22
@CarlosEpia CarlosEpia restored the fixes/#776-missing-egon100RE-power-plants-and-reservoir-run_of_river branch June 23, 2022 07:23
@CarlosEpia CarlosEpia deleted the fixes/#776-missing-egon100RE-power-plants-and-reservoir-run_of_river branch June 23, 2022 07:38
@CarlosEpia CarlosEpia restored the fixes/#776-missing-egon100RE-power-plants-and-reservoir-run_of_river branch February 14, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ClaraBuettner ClaraBuettner ClaraBuettner approved these changes

@IlkaCu IlkaCu Awaiting requested review from IlkaCu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing reservoir and run_of_river power plants in eTraGo tables
2 participants
@CarlosEpia @ClaraBuettner