Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CH4 stores in Germany for eGon100RE and adjust grid pipeline capcities (CH4 and H2) #793

Merged
merged 14 commits into from
Jun 16, 2022

Conversation

AmeliaNadal
Copy link
Contributor

@AmeliaNadal AmeliaNadal commented Jun 2, 2022

Will partially solve #779 and #686

Before merging into dev-branch, please make sure that

  • the CHANGELOG.rst was updated.
  • new and adjusted code is formated using black and isort.
  • the Dataset-version is updated when existing datasets are adjusted.
  • the branch was merged into the
    continuous-integration/run-everything-over-the-weekend-branch.
  • the workflow is running successful in test mode.
  • the workflow is running successful in Everything mode.

Remaining tasks

  • Insert retroffited H2 storages
  • CH4 stores abroad

@AmeliaNadal AmeliaNadal self-assigned this Jun 2, 2022
@AmeliaNadal AmeliaNadal requested a review from fwitte June 2, 2022 14:14
@AmeliaNadal AmeliaNadal removed the request for review from fwitte June 3, 2022 13:27
@fwitte
Copy link
Member

fwitte commented Jun 3, 2022

@AmeliaNadal: I created the PR #796 based on this branch, since they suit each other quite well. You can just merge that into here (I tested it, both your and my changes did work on a clean run) before merging into dev. I have updated the changelog respectively.

Last thing missing on the storages is then the retroffited H2 storages, I think. For that I will use a function introduced in #790 to calculate the H2 storage capacity, given pressure regime stays the same for hydrogen storage in a retrofitted CH4 storage (pure H2 storage at the same pressure, temperature and volume is only about 30 % of the pure CH4 storage capacity with respect to LHV).

@AmeliaNadal AmeliaNadal marked this pull request as ready for review June 7, 2022 16:44
@AmeliaNadal AmeliaNadal changed the title Add CH4 stores for eGon100RE in Germany Add CH4 stores in Germany for eGon100RE and adjust grid pipeline capcities (CH4 and H2) Jun 8, 2022
@AmeliaNadal AmeliaNadal merged commit 7863805 into dev Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants