Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes/#683 crossborder lines without dlr #697

Merged
merged 3 commits into from
Mar 10, 2022
Merged

Fixes/#683 crossborder lines without dlr #697

merged 3 commits into from
Mar 10, 2022

Conversation

CarlosEpia
Copy link
Contributor

Fixes #683.

Before merging into dev-branch, please make sure that

  • the CHANGELOG.rst was updated.
  • new and adjusted code is formated using black and isort.
  • the Dataset-version is updated when existing datasets are adjusted.
  • the branch was merged into the continuous-integration/run-everything-over-the-weekend-v2- branch.
  • the workflow is running successful in test mode.
  • the workflow is running successful in Everything mode.

ulfmueller
ulfmueller approved these changes Mar 10, 2022
View reviewed changes
Copy link
Member

@ulfmueller ulfmueller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just from looking at the code I approve it. If you successfully tested the result thoroughly then I would refrain from testing it also.

@CarlosEpia CarlosEpia merged commit 9c7f239 into dev Mar 10, 2022
@CarlosEpia CarlosEpia deleted the fixes/#683-Crossborder-lines-without-DLR branch March 14, 2022 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ulfmueller ulfmueller ulfmueller approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cross-border lines without DLR time-series
2 participants
@CarlosEpia @ulfmueller