Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Features/#587 update osm residential buildings #666

Merged
merged 20 commits into from
Feb 24, 2022
Merged

Features/#587 update osm residential buildings #666

merged 20 commits into from
Feb 24, 2022

Conversation

nesnoj
Copy link
Member

@nesnoj nesnoj commented Feb 21, 2022 •
edited
Loading

Fixes #587.

Before merging into dev-branch, please make sure that

  • the CHANGELOG.rst was updated.
  • new and adjusted code is formated using black and isort.
  • the Dataset-version is updated when existing datasets are adjusted.
  • the branch was merged into the continuous-integration/run-everything-over-the-weekend-v2- branch.
  • the workflow is running successful in test mode.
  • the workflow is running successful in Everything mode.

@nesnoj nesnoj requested a review from nailend February 21, 2022 16:32
@nesnoj nesnoj self-assigned this Feb 21, 2022
@nesnoj nesnoj marked this pull request as draft February 22, 2022 13:44
@nesnoj nesnoj marked this pull request as ready for review February 24, 2022 10:15
nailend
nailend approved these changes Feb 24, 2022
View reviewed changes
Copy link
Contributor

@nailend nailend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks fine but maybe bump to version 2 for oms_buildings_streets is enough?
Checked the hh demand data at nuts3 and compared to demand-regio! Go

@nesnoj nesnoj merged commit e860dfd into dev Feb 24, 2022
@nesnoj nesnoj deleted the features/#587-update-osm-residential-buildings branch February 24, 2022 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nailend nailend nailend approved these changes

Assignees

@nesnoj nesnoj

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add new building table for residential
2 participants
@nesnoj @nailend