Features/#405 insert ch4 storages #472
Conversation
| gas_storages_list = gas_storages_list.reset_index(drop=True) | ||
|
|
||
| # Insert data to db | ||
| print(gas_storages_list) |
There was a problem hiding this comment.
Is this print statement necessary or can it be deleted?
There was a problem hiding this comment.
I deleted this print statement.
| """ | ||
| Gas_grid_capacity = 130000 # G.Volk "Die Herauforderung an die Bundesnetzagentur die Energiewende zu meistern" Berlin, Dec 2012 | ||
| N_ch4_nodes_G = ch4_nodes_number_G(define_gas_nodes_list()) # Number of nodes in Germany | ||
| print(N_ch4_nodes_G) |
There was a problem hiding this comment.
Is this print statement necessary or can it be deleted?
There was a problem hiding this comment.
I deleted this print statement.
…m/openego/eGon-data into features/#405-insert-ch4-storages
|
|
||
|
|
||
| def import_ch4_grid_capacity(): | ||
| """Define dataframe containing the gas storage modelling the ch4 grid storage capacity |
There was a problem hiding this comment.
Could you add some more information about the distribution of the stores/grid capacity here?
There was a problem hiding this comment.
I added some more information about the modelling of the CH4 grid storage capacity (and open an issue to improve this modelling).
|
I run the code successfully and also had a look at the code. If you could add some more documentation about the comment (see above), I will approve this PR. |
Closes #405
This branch has been merged into the CI-branch.