Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Features/#328 demands to etra go table #379

Merged
merged 7 commits into from
Aug 11, 2021
Merged

Features/#328 demands to etra go table #379

merged 7 commits into from
Aug 11, 2021

Conversation

IlkaCu
Copy link
Member

@IlkaCu IlkaCu commented Aug 10, 2021

Fixes #328

@IlkaCu IlkaCu self-assigned this Aug 10, 2021
@IlkaCu
Copy link
Member Author

IlkaCu commented Aug 10, 2021

Household demands need to be added as soon as available.

ClaraBuettner
ClaraBuettner reviewed Aug 10, 2021
View reviewed changes
src/egon/data/datasets/electricity_demand_etrago.py Outdated
from sqlalchemy.ext.declarative import declarative_base


Base = declarative_base()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

declarative_base and Base are not needed in the script later on. So lines 11 and 14 could be deleted.

ClaraBuettner
ClaraBuettner approved these changes Aug 10, 2021
View reviewed changes
Copy link
Contributor

@ClaraBuettner ClaraBuettner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I run the branch successfully for Schleswig-Holstein and also checked that the data was inserted. Since there is only one minor comment which doesn't change the functions, I approve this.

@IlkaCu IlkaCu merged commit 7de1a83 into dev Aug 11, 2021
@IlkaCu IlkaCu deleted the features/#328-demands-to-etraGo-table branch August 11, 2021 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ClaraBuettner ClaraBuettner ClaraBuettner approved these changes

Assignees

@IlkaCu IlkaCu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add totalized demand curves to eTraGo tables
2 participants
@IlkaCu @ClaraBuettner