Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing heat demand profiles for zensus cells close to German border #585

Closed
ClaraBuettner opened this issue Dec 17, 2021 · 0 comments · Fixed by #594
Closed

Missing heat demand profiles for zensus cells close to German border #585

ClaraBuettner opened this issue Dec 17, 2021 · 0 comments · Fixed by #594
Assignees
@ClaraBuettner
Labels
🐛 bug Something isn't working

Comments

@ClaraBuettner
Copy link
Contributor

ClaraBuettner commented Dec 17, 2021 •
edited by nesnoj
Loading

Some zensus cells close to the German border are not intersecting with the climate_zone shape file. These cells get lost in these lines:

eGon-data/src/egon/data/datasets/heat_demand_timeseries/HTS.py

Lines 629 to 631 in 0730acf

demand_zone = gpd.sjoin(
demand_geom, temperature_zones, how="inner", op="intersects"
)

Can be fixed by using gpd.sjoin_nearest() instead of gpd.sjoin()

Waits for #558
@ClaraBuettner ClaraBuettner added the 🐛 bug Something isn't working label Dec 17, 2021
@ClaraBuettner ClaraBuettner self-assigned this Dec 17, 2021
@ClaraBuettner ClaraBuettner mentioned this issue Dec 17, 2021
Merged
6 tasks
ClaraBuettner added a commit that referenced this issue Dec 21, 2021
@ClaraBuettner
Merge branch 'fixes/#585-heat-demand-profiles-at-border' into continu…
2495783 
…ous-integration/run-everything-over-the-weekend
@ClaraBuettner ClaraBuettner mentioned this issue Dec 21, 2021
Merged
6 tasks
ClaraBuettner added a commit that referenced this issue Dec 22, 2021
@ClaraBuettner
Merge branch 'dev' into fixes/#585-heat-demand-profiles-at-border
66d764a
ClaraBuettner added a commit that referenced this issue Jan 3, 2022
@ClaraBuettner
Merge branch 'dev' into fixes/#585-heat-demand-profiles-at-border
2f528ad
ClaraBuettner added a commit that referenced this issue Jan 3, 2022
@ClaraBuettner
Merge pull request #594 from openego/fixes/#585-heat-demand-profiles-…
402082e 
…at-border

Fixes/#585 heat demand profiles at border
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ClaraBuettner ClaraBuettner

Labels
🐛 bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes/#585 heat demand profiles at border openego/eGon-data
1 participant
@ClaraBuettner