Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The geopandas overlay function API works differently in geopandas 0.10.0 than before #504

Closed
fwitte opened this issue Nov 9, 2021 · 2 comments · Fixed by #506
Closed
Assignees

Comments

@fwitte
Copy link
Member

fwitte commented Nov 9, 2021

I have geopandas==0.10.0 installed locally, the CI branch did run on geopandas==0.9.0. The overlay method changed from

geopandas.overlay(gdf1, gdf2) to gdf1.overlay(gdf2) (see Changelog, third bullet in highlights: https://geopandas.org/en/stable/docs/changelog.html#version-0-10-0-october-3-2021)

What should we do here? Use 0.9.0 API in our code or make the server install the latest geopandas version? egon-data setup allows for both versions:

"geopandas>=0.9.0",

Other packages requiring geopandas are atlite

https://github.com/PyPSA/atlite/blob/e1127d9946fdff4e5c2f63a2cb674147817d3ca4/setup.py#L44

and disaggregator

https://github.com/DemandRegioTeam/disaggregator/blob/2bdb37ed9f92ce7a1c4fd9040c6ec6b00680ef85/environment.yml#L14.

Neither of them (in latest state) restricts the geopandas version.

@fwitte fwitte self-assigned this Nov 9, 2021
@fwitte
Copy link
Member Author

fwitte commented Nov 10, 2021

I tested a run with geopandas==0.9.0 locally and it produces the same errors regarding substation/bus mapping as described in #488. Therefore I do not see a reason, why we should keep geopandas>=0.9.0.

@fwitte
Copy link
Member Author

fwitte commented Nov 10, 2021

@gnn: Any idea, why version geopandas==0.9.0 is installed with requirement geopandas>=0.9.0 although none of the dependants poses any restrictions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant