Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change gid columns to id columns #169

Closed
3 tasks
gplssm opened this issue Mar 22, 2021 · 2 comments · Fixed by #428
Closed
3 tasks

Change gid columns to id columns #169

gplssm opened this issue Mar 22, 2021 · 2 comments · Fixed by #428
Assignees
@KathiEsterl

Comments

@gplssm
Copy link
Contributor

gplssm commented Mar 22, 2021

VG250 and zensus_vg250 tables use gid as name for the primary key column. According to the decision in this should be changed to id. Affects

  • All VG250 tables
  • Processing steps that combine vg250 and zensus
  • Potentially all subsequent processing steps that work on data results from the two above
@gplssm gplssm self-assigned this Mar 22, 2021
@IlkaCu IlkaCu assigned KathiEsterl and unassigned gplssm Jul 15, 2021
@IlkaCu
Copy link
Member

IlkaCu commented Jul 15, 2021

@KathiEsterl: Could you please take over this task? Beside the vg250 and zensus_vg250 tables please also check the other tables in our workflow for gid columns and rename them to id.

@KathiEsterl
Copy link
Contributor

I will work on this task here: https://github.com/openego/eGon-data/tree/features/%23169-renaming-gid-and-subst_id
This branch combines the issues explained above (gid -> id) and the renaming explained in issue #335 (subst_id -> bus_id).

@KathiEsterl KathiEsterl mentioned this issue Aug 17, 2021
Closed
KathiEsterl added a commit that referenced this issue Aug 23, 2021
@KathiEsterl
Merge branch 'dev' into features/#169-renaming-gid-and-subst_id
cc4fc0f
KathiEsterl added a commit that referenced this issue Aug 26, 2021
@KathiEsterl
Merge branch 'dev' into features/#169-renaming-gid-and-subst_id
62e9989
KathiEsterl added a commit that referenced this issue Sep 3, 2021
@KathiEsterl
Merge branch 'dev' into features/#169-renaming-gid-and-subst_id
95b3bf3
KathiEsterl added a commit that referenced this issue Sep 3, 2021
@KathiEsterl
merge of renaming gid->id (branch #169)
5ad291e
@KathiEsterl KathiEsterl mentioned this issue Sep 7, 2021
Merged
KathiEsterl added a commit that referenced this issue Sep 8, 2021
@KathiEsterl
Merge pull request #428 from openego/features/#169-renaming-gid-and-s…
0d79443 
…ubst_id

Features/#169 renaming gid and subst
KathiEsterl added a commit that referenced this issue Sep 28, 2021
@KathiEsterl
Merge branch 'dev' into features/#169-renaming-gid-and-subst_id
48b5450
KathiEsterl added a commit that referenced this issue Sep 28, 2021
@KathiEsterl
Merge pull request #446 from openego/features/#169-renaming-gid-and-s…
eed23e4 
…ubst_id

changed column name subst_id to bus_id
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KathiEsterl KathiEsterl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Features/#169 renaming gid and subst openego/eGon-data
3 participants
@gplssm @IlkaCu @KathiEsterl