-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Option for running workflow in test mode #112
Comments
The switch for choosing the test mode can be implemented best using parameters passed to the dag as described on StackOverflow. |
I the last eGon-data webco we've decided to use a separate database for running the workflow on test data. This decision was prepared by a dicussion between @IlkaCu and @gnn. @ClaraBuettner and @gplssm decided to wait here, until we moved forward regarding setting up this separate database with test data. |
Since we decided today that choosing a database and choosing the testmode or not is linked, default_args seemed to be a good way to go for me. But then, I read that I would like to avoid using parameters as proposed in #112 (comment). As I explained above, we already chose to use the testmode via a CLI flag. So, we don't need to tell this twice passing airflow parameters. I simply suggest to introduce an additional argument for each function that needs to know that a run is triggered in testmode. It might make sense to use a global variable for that in |
I think that's fine. We need to update every function to use the test case, adding an argument doesn't seem to be more effort. And I wrote some lines that create a subset of vg250, I would like to push this. Can simply I create a branch for this issue which we use to implement the testcase for all datasets? |
After my last comment I though about making use of the new, decentralized
Please, feel free to to create a branch and push your code 🚀 |
Here is the branch with my commits: https://github.com/openego/eGon-data/tree/features/%23112-option-testmode |
You mean passing the parameter
👍 |
We should discuss conceptionally if we want |
I'm more than a bit against sprinkling such an option everywhere because it looks like noise instead of useful information. As I said on Monday, this rather looks like something which should be placed in a configuration file, or in a table storing configuration information in the database. Maybe we can talk about this tomorrow. |
…enego/eGon-data into features/#112-option-testmode
The script of @gnn which cuts the zenus data is integrated. I decided not to delete the reduced files to reduce the computation time. If you don't like this, I can also change this again. The overall execution time (including cutting zensus data) is ~ 25 min. I also replaced the |
The nep input data is now also available in test mode. I decided to scale district heating capacities per population share because the demand is more linked to population than to area. |
I double-check that it run successfully on my side. Afterswards, I do the remaining open tasks above and create another issue for the second database stuff that @gnn is working on |
The test mode including all cutting took 29 mins for. But I think I had already most of the data on my disk and download tasks were mostly skipped |
I gonna reopen for @gnn... |
Since running the workflow with the dataset for entire Germany has too long computation time for effective testing, a test mode with a subset of this data (i.e. a single federal state) is needed. Activating this test mode then instructs the workflow to run only on this subset of data.
Tasks
The text was updated successfully, but these errors were encountered: