-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
413 feature improve connection of charging points #421
base: dev
Are you sure you want to change the base?
Conversation
logger.error(f"Component type {comp_type} is not a valid option.") | ||
return | ||
elif comp_type in ["generator", "storage_unit"]: | ||
comp_data["p_nom"] = comp_data["p"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do you need this? Above, p is set, so that all have p. Setting both seems redundant.
@joda9 some tests are failing now because I used your new function geo.calculate_distance_to_buses_df() in geo.find_nearest_bus(). I don't get, why it would change the calculated distance, because geopy.distance.distance uses geodesic, which was used before in geo.find_nearest_bus(). Also, changing distance.distance to distance.geodesic didn't fix the problem. So it must be something else that's different in your function. Could you try to find out, what it is? |
Description
This update enhances the
connect_to_lv_based_on_geolocation
function with the following improvements:Charging Point Connection:
Load Distribution Across Buses:
MV Bus Connection:
Updated Documentation:
Fixes #413
Type of change
Please delete options that are not relevant.
Bug fix (non-breaking change which fixes an issue)Checklist:
pre-commit
hooksIf new packages are needed, I added them the setup.py, and if needed the rtd_requirements.txt, the eDisGo_env.yml and the eDisGo_env_dev.yml.