Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

413 feature improve connection of charging points #421

Open
wants to merge 53 commits into
base: dev
Choose a base branch
from

Conversation

joda9
Copy link
Collaborator

@joda9 joda9 commented Sep 6, 2024

Description

This update enhances the connect_to_lv_based_on_geolocation function with the following improvements:

  1. Charging Point Connection:

    • Charging points are now connected to the nearest load bus, matching them with the appropriate load type:
      • Residential Loads: For home charging.
      • Industrial or CTS Loads: For workplace charging.
      • Public Charging: Connected to buses without associated buildings.
  2. Load Distribution Across Buses:

    • The function checks the number of similar load types already connected to each bus and selects the bus with the fewest connections.
  3. MV Bus Connection:

    • The function now allows for connections to a Medium Voltage (MV) bus if permitted and if the MV bus is significantly closer than a Low Voltage (LV) bus or a substation, improving overall network efficiency.
  4. Updated Documentation:

    • The docstring for connect_to_lv_based_on_geolocation has been revised to accurately reflect these changes, offering clear instructions on the function's updated behavior.

Fixes #413

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • New and adjusted code is formatted using the pre-commit hooks
  • New and adjusted code includes type hinting now
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • The Read the Docs documentation is compiling correctly
  • If new packages are needed, I added them the setup.py, and if needed the rtd_requirements.txt, the eDisGo_env.yml and the eDisGo_env_dev.yml.
  • I have added new features to the corresponding whatsnew file

joda9 and others added 30 commits August 6, 2024 11:28
…f-charging-points-kh

413 feature improve connection of charging points kh
…ithub.com:openego/eDisGo into 413-feature-improve-connection-of-charging-points
edisgo/network/topology.py Outdated Show resolved Hide resolved
edisgo/network/topology.py Outdated Show resolved Hide resolved
edisgo/network/topology.py Outdated Show resolved Hide resolved
edisgo/network/topology.py Outdated Show resolved Hide resolved
edisgo/network/topology.py Outdated Show resolved Hide resolved
edisgo/network/topology.py Outdated Show resolved Hide resolved
edisgo/network/topology.py Outdated Show resolved Hide resolved
edisgo/network/topology.py Outdated Show resolved Hide resolved
logger.error(f"Component type {comp_type} is not a valid option.")
return
elif comp_type in ["generator", "storage_unit"]:
comp_data["p_nom"] = comp_data["p"]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you need this? Above, p is set, so that all have p. Setting both seems redundant.

@birgits
Copy link
Collaborator

birgits commented Sep 13, 2024

@joda9 some tests are failing now because I used your new function geo.calculate_distance_to_buses_df() in geo.find_nearest_bus(). I don't get, why it would change the calculated distance, because geopy.distance.distance uses geodesic, which was used before in geo.find_nearest_bus(). Also, changing distance.distance to distance.geodesic didn't fix the problem. So it must be something else that's different in your function. Could you try to find out, what it is?

@joda9 joda9 closed this Sep 23, 2024
@joda9 joda9 deleted the 413--feature--improve-connection-of-charging-points branch September 23, 2024 11:35
@joda9 joda9 restored the 413--feature--improve-connection-of-charging-points branch September 26, 2024 08:14
@joda9 joda9 reopened this Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Improve connection of charging points
3 participants