Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added a search feature on skill field in CourseSkills #203

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

jajjibhai008
Copy link
Contributor

Description

Screen.Recording.2024-08-22.at.7.29.10.PM.mov

Merge checklist:

  • Any new requirements are in the right place (do not manually modify the requirements/*.txt files)
    • make upgrade && make requirements have been run to regenerate requirements
  • ./manage.py makemigrations has been run
    • Checkout the Database Migration Confluence page for helpful tips on creating migrations.
    • Note: This must be run if you modified any models.
      • It may or may not make a migration depending on exactly what you modified, but it should still be run.
  • Version bumped
  • Changelog record added

Post merge:

  • Tag pushed and a new version released
    • Note: Assets will be added automatically. You just need to provide a tag (should match your version number) and title and description.
  • After versioned build finishes in GitHub Actions, verify version has been pushed to PyPI
    • Each step in the release build has a condition flag that checks if the rest of the steps are done and if so will deploy to PyPi.
      (so basically once your build finishes, after maybe a minute you should see the new version in PyPi automatically (on refresh))
  • PR created in course-discovery to upgrade dependencies (including taxonomy-connector)
    • This must be done after the version is visible in PyPi as make upgrade in course-discovery will look for the latest version in PyPi.

Copy link
Contributor

@muhammad-ammar muhammad-ammar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@muhammad-ammar
Copy link
Contributor

@jajjibhai008 If it is not too much work then can we only show the skill name in dropdown? Currently it also show the external_id.

@irfanuddinahmad Please share your thoughts.

@jajjibhai008
Copy link
Contributor Author

@jajjibhai008 If it is not too much work then can we only show the skill name in dropdown? Currently it also show the external_id.

@irfanuddinahmad Please share your thoughts.

@muhammad-ammar I can implement that but the creator of the ticket agreed on the current implementation.

@jajjibhai008 jajjibhai008 merged commit fa41dc7 into master Aug 23, 2024
10 checks passed
@jajjibhai008 jajjibhai008 deleted the eahmadjaved/ENT-9301 branch August 23, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants