Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed some implementation issues in job recommendation logic. #174

Merged
merged 1 commit into from
Aug 2, 2023

Conversation

saleem-latif
Copy link
Contributor

@saleem-latif saleem-latif commented Aug 2, 2023

Jira Ticket: ENT-7294

Description:
Fixed some implementation issues in job recommendation logic.

Merge checklist:

  • Any new requirements are in the right place (do not manually modify the requirements/*.txt files)
    • make upgrade && make requirements have been run to regenerate requirements
  • ./manage.py makemigrations has been run
    • Checkout the Database Migration Confluence page for helpful tips on creating migrations.
    • Note: This must be run if you modified any models.
      • It may or may not make a migration depending on exactly what you modified, but it should still be run.
  • Version bumped
  • Changelog record added

Post merge:

  • Tag pushed and a new version released
    • Note: Assets will be added automatically. You just need to provide a tag (should match your version number) and title and description.
  • After versioned build finishes in GitHub Actions, verify version has been pushed to PyPI
    • Each step in the release build has a condition flag that checks if the rest of the steps are done and if so will deploy to PyPi.
      (so basically once your build finishes, after maybe a minute you should see the new version in PyPi automatically (on refresh))
  • PR created in course-discovery to upgrade dependencies (including taxonomy-connector)
    • This must be done after the version is visible in PyPi as make upgrade in course-discovery will look for the latest version in PyPi.

@saleem-latif saleem-latif merged commit 786a589 into master Aug 2, 2023
7 checks passed
@saleem-latif saleem-latif deleted the saleem-latif/ENT-7234-updates branch August 2, 2023 12:50
@@ -16,6 +16,7 @@
'searchable(skills.name)',
'searchable(industry_names)',
'searchable(b2c_opt_in)'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@saleem-latif There is a missing comma here, and b2c_opt_in values are no longer showing up in the index

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants