-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Update VideoConfigService get_transcript method #37809
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
a5b790c to
9d02fbc
Compare
feanil
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change look good, be sure to add testing notes and I can re-review when that's done.
9d02fbc to
7d03b58
Compare
7d03b58 to
dfe6525
Compare
|
Sandbox deployment successful 🚀 |
|
Sandbox deployment successful 🚀 |
Update method for the bumper videos
dfe6525 to
7781a8d
Compare
|
Sandbox deployment successful 🚀 |
Description
This moves edx-platform-specific logic out of the VideoBlock, in preparation for the VideoBlock extraction:
#36282
Testing instructions
Testing has been done on the sandbox created within this PR.
Note: Bumper video testing can't be done as not frontend exist for this feature. It seems un-used feature for some time. Test cases are passing so we can assume its functionality will be un-changed in this PR.
Acceptance Criteria: