Skip to content

move get_transcript method to video service #37635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
farhan merged 1 commit into from
Dec 5, 2025
Merged

move get_transcript method to video service #37635

farhan merged 1 commit into from
Dec 5, 2025
+102 −33

Conversation

@farhan
Copy link
Contributor

@farhan farhan commented Nov 14, 2025 •
edited
Loading

openedx/public-engineering#430

VideoConfigService injection in XBlock runtime:

VideoConfigService has been added to the XBlock runtime in this commit to fix this test case.

Testing instructions

Go to studio, and in a course, Stream any video having transcript. Transcripts should load properly.
Do the same with a v2 library Video Unit.

@kdmccormick kdmccormick force-pushed the farhan/move-transcripts-utils branch from 8b9f59c to 909c628 Compare November 14, 2025 18:04
Base automatically changed from farhan/move-transcripts-utils to master November 14, 2025 18:26
@farhan farhan force-pushed the farhan/move-get-transcript branch from a2e06e0 to 539d770 Compare November 17, 2025 13:23
@farhan farhan force-pushed the farhan/move-get-transcript branch 6 times, most recently from d77bac0 to 7e9576f Compare November 25, 2025 15:40
@farhan farhan added the create-sandbox open-craft-grove should create a sandbox environment from this PR label Nov 25, 2025
@open-craft-grove
Copy link

open-craft-grove commented Nov 25, 2025

Sandbox deployment failed 💥
Please check the settings and requirements.
Retry deployment by pushing a new commit or updating the requirements/settings in the pull request's description.
📜 Failure Logs
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@open-craft-grove
Copy link

open-craft-grove commented Nov 26, 2025

Sandbox deployment failed 💥
Please check the settings and requirements.
Retry deployment by pushing a new commit or updating the requirements/settings in the pull request's description.
📜 Failure Logs
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@open-craft-grove
Copy link

open-craft-grove commented Nov 26, 2025

Sandbox deployment failed 💥
Please check the settings and requirements.
Retry deployment by pushing a new commit or updating the requirements/settings in the pull request's description.
📜 Failure Logs
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@farhan farhan closed this Nov 26, 2025
@farhan farhan reopened this Nov 26, 2025
@open-craft-grove
Copy link

open-craft-grove commented Nov 26, 2025

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@farhan farhan marked this pull request as ready for review November 26, 2025 11:49
@farhan farhan requested review from feanil and kdmccormick November 26, 2025 11:49
@farhan
Copy link
Contributor Author

farhan commented Nov 26, 2025 •
edited
Loading

@kyle McCormick Following commit is the fix of a test case. I need your assistance in fixing it.
Context: Following is the fix of a djangoapps/content_libraries test case that needs VideoConfigService in the runtime.
7e9576f

@farhan farhan mentioned this pull request Nov 26, 2025
Closed
@farhan farhan force-pushed the farhan/move-get-transcript branch from 7e9576f to 175d670 Compare December 2, 2025 11:04
@open-craft-grove
Copy link

open-craft-grove commented Dec 2, 2025

Sandbox deployment failed 💥
Please check the settings and requirements.
Retry deployment by pushing a new commit or updating the requirements/settings in the pull request's description.
📜 Failure Logs
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@farhan farhan force-pushed the farhan/move-get-transcript branch from 175d670 to 11f8141 Compare December 2, 2025 11:56
@open-craft-grove
Copy link

open-craft-grove commented Dec 3, 2025

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@open-craft-grove
Copy link

open-craft-grove commented Dec 3, 2025

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@open-craft-grove
Copy link

open-craft-grove commented Dec 3, 2025

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@farhan farhan force-pushed the farhan/move-get-transcript branch from 985bbb0 to 05db2d5 Compare December 3, 2025 12:10
@farhan farhan force-pushed the farhan/move-get-transcript branch from 05db2d5 to fa93cfd Compare December 3, 2025 12:45
@open-craft-grove
Copy link

open-craft-grove commented Dec 3, 2025

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@open-craft-grove
Copy link

open-craft-grove commented Dec 3, 2025

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@farhan farhan force-pushed the farhan/move-get-transcript branch 4 times, most recently from 46bb4f2 to 91d2596 Compare December 4, 2025 12:20
@open-craft-grove
Copy link

open-craft-grove commented Dec 4, 2025

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@farhan farhan force-pushed the farhan/move-get-transcript branch 2 times, most recently from 2d36864 to 5c2106e Compare December 4, 2025 13:25
@open-craft-grove
Copy link

open-craft-grove commented Dec 4, 2025

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@open-craft-grove
Copy link

open-craft-grove commented Dec 4, 2025

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@open-craft-grove
Copy link

open-craft-grove commented Dec 4, 2025

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@open-craft-grove
Copy link

open-craft-grove commented Dec 4, 2025

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@open-craft-grove
Copy link

open-craft-grove commented Dec 4, 2025

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

kdmccormick
kdmccormick approved these changes Dec 4, 2025
View reviewed changes
Copy link
Member

@kdmccormick kdmccormick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

just a couple comments. feel free to merge if you address them.

kdmccormick
kdmccormick reviewed Dec 4, 2025
View reviewed changes
Copy link
Member

@kdmccormick kdmccormick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(these go with my other comment)

@farhan farhan closed this Dec 5, 2025
@farhan farhan reopened this Dec 5, 2025
@open-craft-grove
Copy link

open-craft-grove commented Dec 5, 2025

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@farhan farhan force-pushed the farhan/move-get-transcript branch from 6d50c7c to 6d0e3ea Compare December 5, 2025 10:40
@open-craft-grove
Copy link

open-craft-grove commented Dec 5, 2025

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@open-craft-grove
Copy link

open-craft-grove commented Dec 5, 2025

Sandbox deployment failed 💥
Please check the settings and requirements.
Retry deployment by pushing a new commit or updating the requirements/settings in the pull request's description.
📜 Failure Logs
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@open-craft-grove
Copy link

open-craft-grove commented Dec 5, 2025

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@farhan farhan merged commit b57e2ac into master Dec 5, 2025
53 checks passed
@farhan farhan deleted the farhan/move-get-transcript branch December 5, 2025 12:53
mraman-2U pushed a commit to mraman-2U/edx-platform that referenced this pull request Dec 24, 2025
@farhan @mraman-2U
chore: move get_transcript method to video service (openedx#37635)
e527f0a 
openedx/public-engineering#445
@farhan farhan mentioned this pull request Jan 23, 2026
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kdmccormick kdmccormick kdmccormick approved these changes

@irtazaakram irtazaakram Awaiting requested review from irtazaakram irtazaakram is a code owner

@salman2013 salman2013 Awaiting requested review from salman2013 salman2013 is a code owner

@feanil feanil Awaiting requested review from feanil

Assignees

No one assigned

Labels

create-sandbox open-craft-grove should create a sandbox environment from this PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@farhan @open-craft-grove @kdmccormick