Skip to content

[PROD-1440] - Update Done xblock to latest version. #23769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
saadyousafarbi merged 1 commit into from
Apr 21, 2020
Merged

[PROD-1440] - Update Done xblock to latest version. #23769

saadyousafarbi merged 1 commit into from
Apr 21, 2020

Conversation

@saadyousafarbi
Copy link
Contributor

@saadyousafarbi saadyousafarbi commented Apr 20, 2020

PROD-1440

Update Done xblock after handling xblock.fragment DeprecationWarning in this PR and drafting new release

DawoudSheraz
DawoudSheraz approved these changes Apr 20, 2020
View reviewed changes
Copy link
Contributor

@DawoudSheraz DawoudSheraz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 once the tests pass

@saadyousafarbi
Copy link
Contributor Author

saadyousafarbi commented Apr 20, 2020

jenkins run js

@edx-status-bot
Copy link

edx-status-bot commented Apr 20, 2020

Your PR has finished running tests. There were no failures.

@saadyousafarbi saadyousafarbi merged commit 9b469f6 into master Apr 21, 2020
@saadyousafarbi saadyousafarbi deleted the saad/PROD-1440-update-done-xblock branch April 21, 2020 11:33
@edx-pipeline-bot
Copy link
Contributor

edx-pipeline-bot commented Apr 21, 2020

EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

edx-pipeline-bot commented Apr 21, 2020

EdX Release Notice: This PR has been deployed to the production environment.

@edx-pipeline-bot
Copy link
Contributor

edx-pipeline-bot commented Apr 21, 2020

EdX Release Notice: This PR may have caused e2e tests to fail on Stage. If you're a member of the edX org, please visit #e2e-troubleshooting on Slack to help diagnose the cause of these failures. Otherwise, it is the reviewer's responsibility. E2E tests have failed. https://gocd.tools.edx.org/go/tab/pipeline/history/deploy_to_stage

@edx-pipeline-bot
Copy link
Contributor

edx-pipeline-bot commented Apr 21, 2020

EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

edx-pipeline-bot commented Apr 21, 2020

EdX Release Notice: This PR has been deployed to the production environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@awaisdar001 awaisdar001 awaisdar001 approved these changes

@DawoudSheraz DawoudSheraz DawoudSheraz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@saadyousafarbi @edx-status-bot @edx-pipeline-bot @awaisdar001 @DawoudSheraz