Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove deprecated codecov package to avoid failures #80

Merged
merged 1 commit into from
Apr 18, 2023

Conversation

mariajgrimaldi
Copy link
Member

Description:
This PR removes the codecov pypi package which was deprecaded according to its the codevo.io page: https://about.codecov.io/blog/message-regarding-the-pypi-package/

ISSUE:
https://discuss.openedx.org/t/codecov-python-package-removal/9817

Dependencies:
None

Merge deadline:
ASAP so new PRs don't fail

Installation instructions:
Requirements files upgrade only

Testing instructions:
Requirements files upgrade only

Reviewers:

Merge checklist:

  • All reviewers approved
  • CI build is green
  • Version bumped
  • Changelog record added
  • Documentation updated (not only docstrings)
  • Commits are squashed

Post merge:

  • Create a tag
  • Check new version is pushed to PyPI after tag-triggered build is
    finished.
  • Delete working branch (if not needed anymore)

Author concerns:
codecov replacement 🤔, for more info about the current work of the replacement check: https://openedx.atlassian.net/wiki/spaces/COMM/pages/3730931713/2023-04-14+Maintainer+s+Office+Hours+Notes

@openedx-webhooks
Copy link

Thanks for the pull request, @mariajgrimaldi!

As a core committer in this repo, you can merge this once the pull request is approved per the core committer reviewer requirements and according to the agreement with your edX Champion.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Apr 17, 2023
Copy link
Member

@felipemontoya felipemontoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exactly what I would expect the fix to look like. Thanks @mariajgrimaldi

@mariajgrimaldi mariajgrimaldi merged commit 98d8a9f into main Apr 18, 2023
@mariajgrimaldi mariajgrimaldi deleted the MJG/remove-codecov branch April 18, 2023 14:44
@openedx-webhooks
Copy link

@mariajgrimaldi 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core committer open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants