feat: Implement IDV URL Filters #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openedx_filters/learning/filters.py
Outdated
| filter_type = "org.openedx.learning.idv.page.url.requested.v1" | ||
|
|
||
| @classmethod | ||
| def run_filter(cls, url): |
There was a problem hiding this comment.
Could you add type annotations to the method definition, since that seems to be the pattern in this repository, please?
| - The filter must have the signature specified. | ||
| - The filter should return the url. | ||
| """ | ||
| url = Mock(), Mock() |
There was a problem hiding this comment.
I'm curious why you need a tuple here. url should be a single value. Does url = Mock() not work?
There was a problem hiding this comment.
Forgot to remove this when I copy/pasted an earlier test
| - IDVPageURLRequested | ||
| """ | ||
|
|
||
| def test_course_idv_page_url_requested(self): |
There was a problem hiding this comment.
nit: is there a reason that the test case includes course in it? Wondering if it should be:
Suggested change
| def test_course_idv_page_url_requested(self): | |
| def test_idv_page_url_requested(self): |
There was a problem hiding this comment.
Ah, this is another artifact from me copy/pasting tests.
mariajgrimaldi
approved these changes
Sep 19, 2024
|
@ilee2u: please, add an entry to the changelog file so I can proceed with the merge. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: The purpose of this PR is to add an Open edX filter hook for getting the URL to the IDV page to the GitHub - openedx/openedx-filters: Open edX filters from the Hooks Extensions Framework repository.
For the sake of justifying this filter, here is the relevant Open edX Product Proposal and Issue to
Add Extensibility Mechanisms to IDV to Enable Integration of New IDV Vendor Persona.JIRA: Link to JIRA ticket
Dependencies: None
Merge deadline: N/A
Reviewers:
Merge checklist:
Post merge:
finished.