Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add tox 4.0 support #129

Merged
merged 1 commit into from
Nov 15, 2023
Merged

fix: add tox 4.0 support #129

merged 1 commit into from
Nov 15, 2023

Conversation

UsamaSadiq
Copy link
Member

Description

  • Updated tox config to add tox 4.0 support
  • Removed usage of tox-battery from requirements
  • Updated .readthedocs.yml config file to fix the failing docs build check.

@UsamaSadiq UsamaSadiq requested a review from a team as a code owner November 10, 2023 17:50
@UsamaSadiq UsamaSadiq mentioned this pull request Nov 10, 2023
Closed
@iamsobanjaved
Copy link

@openedx/hooks-extension-framework Kindly merge this

felipemontoya
felipemontoya approved these changes Nov 14, 2023
View reviewed changes
Copy link
Member

@felipemontoya felipemontoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. The change is reasonable and the tests are building

@felipemontoya felipemontoya merged commit 6e0ce55 into openedx:main Nov 15, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felipemontoya felipemontoya felipemontoya approved these changes

@iamsobanjaved iamsobanjaved iamsobanjaved approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@UsamaSadiq @iamsobanjaved @felipemontoya