BOM-2988: Replace Travis with GitHub CI

[UsamaSadiq]

Issue: BOM-2988

Description

• Replace Travis with GitHub CI.

[nedbat]

This changes the release trigger from commits to tags. @davidjoy is that in line with fedx practice?

[davidjoy]

@nedbat I'm not sure I follow the commits/tags comment... My understanding is that semantic-release is responsible for creating a tag for the release based on the conventional commit messages in the commits, which is what we do in all our frontend libraries. Does this change that process?

[davidjoy]

Think I'm seeing some issues here w/r/t npm -> npx and a storybook action.

I''l note that in frontend-build we already have a Github release workflow. I'd suggest we keep this one consistent with that: https://github.com/edx/frontend-build/blob/master/.github/workflows/release.yml

[nedbat]

@davidjoy the .travis.yml file had this:

after_success:
- npx semantic-release@17
- codecov

so semantic-release was run after every test run. The new action has:

name: Release CI
on:
  push:
    tags:
      - '*'

so the Release CI action is only run when a new tag is pushed, and it's the Release CI that runs semantic-release.

[davidjoy]

Oh, thank you, I didn't catch that. That sounds like a sane change; I don't know why we'd have semantic-release run anytime except when merging into master.

[nedbat]

I don't know why we'd have semantic-release run anytime except when merging into master.

OK, except this is less frequently than that: only when someone explicitly makes and pushes a tag.

[davidjoy]

Okay, now I'm confused again... semantic-release is responsible for creating the tags and does that as part of its work, after it figures out the version bump based on the commits being merged in to master. We definitely don't want that to become a manual process, and I'm pretty sure semantic-release will fail if the tag already exists.

[codecov-commenter]

Codecov Report

Merging #245 (c2c6970) into master (d1823fa) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #245   +/-   ##
=======================================
  Coverage   80.79%   80.79%           
=======================================
  Files          38       38           
  Lines         885      885           
  Branches      163      163           
=======================================
  Hits          715      715           
  Misses        159      159           
  Partials       11       11           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1823fa...c2c6970. Read the comment docs.

[UsamaSadiq]

@davidjoy I've updated the Release CI to only trigger incase of master branch as it was being done in Travis before. Is this the desired case we want?

[davidjoy]

Think we're missing the Github Pages deploy. Otherwise the release trigger sounds right.

[UsamaSadiq]

@davidjoy I'm not sure about the folder argument. Is the default dict value okay?

[davidjoy]

Yes, I think that should be correct (dist, not dict, of course, but the code is right!)

[davidjoy]

Lets get this in there and see if it works!