-
Notifications
You must be signed in to change notification settings - Fork 153
Enable the use of TypeScript in this repo #604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Thanks for the pull request, @bradenmacdonald! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
@@ -135,6 +135,7 @@ const HeaderBody = ({ | |||
logoutUrl, | |||
authenticatedUserAvatar, | |||
isAdmin, | |||
isMobile, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the only change that could have a runtime effect. Everything else is just test code / type checking.
But TypeScript correctly pointed out that we weren't passing the required isMobile
here. I assume it's correct to just pass it in, but ignoring the real value and passing isMobile: false
would be more consistent with how the code worked before.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #604 +/- ##
==========================================
+ Coverage 68.75% 72.56% +3.81%
==========================================
Files 48 49 +1
Lines 432 492 +60
Branches 97 100 +3
==========================================
+ Hits 297 357 +60
Misses 132 132
Partials 3 3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@brian-smith-tcril Would you be able to take a look at this? |
We're seeing a lot of
defaultProps
deprecation warnings in the JS console when running MFEs.Soon we can use the nice
react-prop-types-typescript
codemod to convert all ourpropTypes
anddefaultProps
to TypeScript/JS defaults. But before we can do that we need to support TypeScript and convert the .jsx files to .tsx.This PR:
frontend-platform
which still doesn't have types; haven't fixed upstream because frontend-base was supposed to do this.src/studio-header
from JSX to TSXThis is only a build/test PR; it should not affect the actual runtime code itself, except for one line that I've called out in a comment.