-
Notifications
You must be signed in to change notification settings - Fork 20
Deprecate react-test-utils other utils 1/2 #378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate react-test-utils other utils 1/2 #378
Conversation
|
Thanks for the pull request, @diana-villalvazo-wgu! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
6d70b6d to
28014be
Compare
28014be to
d84f7d8
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #378 +/- ##
==========================================
- Coverage 90.20% 90.18% -0.03%
==========================================
Files 143 143
Lines 2206 2200 -6
Branches 476 452 -24
==========================================
- Hits 1990 1984 -6
- Misses 204 208 +4
+ Partials 12 8 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
brian-smith-tcril
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this looks great!
I left a couple comments, looking forward to hearing your thoughts!
c527870 to
d12490e
Compare
brian-smith-tcril
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is super close to ready to land!
I left a few more comments in places where it'd be good to add comments with context similar to the ones in FileRenderer/hooks.test.js. Once those are in this should be good to go!
src/components/FilePreview/components/FileRenderer/BaseRenderers/textHooks.test.js
Outdated
Show resolved
Hide resolved
src/views/SubmissionView/hooks/useSubmissionValidationStatus.test.js
Outdated
Show resolved
Hide resolved
src/views/SubmissionView/hooks/useSubmissionValidationStatus.test.js
Outdated
Show resolved
Hide resolved
src/views/SubmissionView/hooks/useSubmissionValidationStatus.test.js
Outdated
Show resolved
Hide resolved
src/views/SubmissionView/hooks/useSubmissionValidationStatus.test.js
Outdated
Show resolved
Hide resolved
src/views/SubmissionView/hooks/useSubmissionValidationStatus.test.js
Outdated
Show resolved
Hide resolved
brian-smith-tcril
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect!
Thanks for working through my questions with me!
Description
On previous effort was missing deprecation of
formatMessage,useKeyedStateandmockUseKeyedStateSo it was addressed on this PR.
formatMessagewe removed it and just use the real defaultMessage to compare on tests.useKeyedStatebyuseStateand in the related testsmockUseKeyedStatewas removed and replaced by a jest spy for native reactuseState.Support Information
Closes #376