-
Notifications
You must be signed in to change notification settings - Fork 301
fix(deps): update dependency redux to v4.2.1 #934
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #934 +/- ##
=======================================
Coverage 89.25% 89.25%
=======================================
Files 318 318
Lines 5563 5563
Branches 1341 1376 +35
=======================================
Hits 4965 4965
+ Misses 583 582 -1
- Partials 15 16 +1 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
7b8751f to
16036d5
Compare
16036d5 to
9d3b0fe
Compare
9d3b0fe to
9cd3f3d
Compare
9cd3f3d to
de50df2
Compare
9093e1c to
67726bc
Compare
67726bc to
c01cbe4
Compare
885ceb6 to
414e6d7
Compare
414e6d7 to
2db9e5d
Compare
5a4d40a to
be53597
Compare
be53597 to
4051191
Compare
4051191 to
1c5fb58
Compare
03ab7d6 to
a0d901e
Compare
e780929 to
261e26c
Compare
550d4bd to
dea2e03
Compare
420741e to
e6e9695
Compare
e6e9695 to
e354064
Compare
3479a03 to
ccf5c0b
Compare
d19f9f9 to
9730737
Compare
b44e106 to
16e04f2
Compare
bccd9fc to
8a7ae5b
Compare
8a7ae5b to
c74bd8a
Compare
fb8841a to
fc1050b
Compare
fc1050b to
2a5452e
Compare
bradenmacdonald
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and didn't see any issues.
This PR contains the following updates:
4.1.2->4.2.1Release Notes
reduxjs/redux (redux)
v4.2.1Compare Source
This bugfix release removes the
isMinifiedinternal check to fix a compat issue with Expo. That check has added in early 2016, soon after Redux 3.0 was released, at a time when it was still less common to use bundlers with proper production build settings. Today that check is irrelevant, so we've removed it.What's Changed
Full Changelog: reduxjs/redux@v4.2.0...v4.2.1
v4.2.0Compare Source
This release marks the original
createStoreAPI as@deprecatedto encourage users to migrate to Redux Toolkit, and adds a newlegacy_createStoreAPI as an alias without the deprecation warning.Goal
Redux Toolkit (the
@reduxjs/toolkitpackage) is the right way for Redux users to write Redux code today:https://redux.js.org/introduction/why-rtk-is-redux-today
Unfortunately, many tutorials are still showing legacy "hand-written" Redux patterns, which result in a much worse experience for users. New learners going through a bootcamp or an outdated Udemy course just follow the examples they're being shown, don't know that RTK is the better and recommended approach, and don't even think to look at our docs.
Given that, the goal is to provide them with a visual indicator in their editor, like
createStore. When users hover over thecreateStoreimport or function call, the doc tooltip recommends usingconfigureStorefrom RTK instead, and points them to that docs page. We hope that new learners will see the strikethrough, read the tooltip, read the docs page, learn about RTK, and begin using it.To be extremely clear:
WE ARE NOT GOING TO ACTUALLY REMOVE THE
createStoreAPI, AND ALL YOUR EXISTING CODE WILL STILL CONTINUE TO WORK AS-IS!We are just marking
createStoreas "deprecated":For additional details, see the extensive discussion in https://github.com/reduxjs/redux/issues/4325 .
Rationale
reduxcore package, or fully deprecate the entirereduxpackage and rename it to@reduxjs/core. Unfortunately, those bring up too many complexities:redux-starter-kitto@reduxjs/toolkit, and all of our docs and tutorials have pointed to it for the last three years. I don't want to put users through another whiplash package transition for no real benefitSo, this is the minimum possible approach we can take to reach out to users who otherwise would never know that they are following outdated patterns, while avoiding breaking running user code or having to completely rewrite our package and repo structure.
Results
When a user imports
createStorein their editor, they will see a visual strikethrough. Hovering over it will show a doc tooltip that encourages them to useconfigureStorefrom RTK, and points to an explanatory docs page:Again, no broken code, and no runtime warnings.
If users do not want to see that strikethrough, they have three options:
configureStorelegacy_createStoreAPI that is now exported, which is the exact same function but with no@deprecationtag. The simplest option is to do an aliased import rename:What's Changed
createStoreas deprecated, and addlegacy_createStorealias by @markerikson in https://github.com/reduxjs/redux/pull/4336Full Changelog: reduxjs/redux@v4.1.2...v4.2.0
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.