-
Notifications
You must be signed in to change notification settings - Fork 295
Centering and aligning previous and next buttons #1718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Centering and aligning previous and next buttons #1718
Conversation
|
Thanks for the pull request, @jacobo-dominguez-wgu! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1718 +/- ##
=======================================
Coverage 90.41% 90.41%
=======================================
Files 343 343
Lines 5781 5781
Branches 1385 1347 -38
=======================================
Hits 5227 5227
- Misses 535 537 +2
+ Partials 19 17 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
wgu-jesse-stewart
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! nice work
wgu-jesse-stewart
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
after taking a second look, I think we need to either remove the flex-basis from the next-button or try a different approach.
|
Could you include "before" screenshots in the PR description as well? Having "before" and "after" would make it a lot easier to see the difference quickly. |
Sure, screenshots added |
arbrandes
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks!
Description
The buttons for previous and next on course content navigation were not aligned correctly.
#1706
Steps to reproduce
Before
Mobile screen
Desktop screen
After
Mobile screen
Desktop screen