Skip to content

Conversation

@jacobo-dominguez-wgu
Copy link
Contributor

@jacobo-dominguez-wgu jacobo-dominguez-wgu commented May 28, 2025

Description

The buttons for previous and next on course content navigation were not aligned correctly.
#1706

Steps to reproduce

  1. Log in to the platform.
  2. Open any course (e.g., Demo course).
  3. Scroll to the bottom of a lesson or content page.
  4. Observe the positioning of the "Next" and "Previous" buttons.

Before

Mobile screen

Captura de pantalla 2025-06-02 a la(s) 9 54 49 a m

Desktop screen

Captura de pantalla 2025-06-02 a la(s) 9 54 23 a m

After

Mobile screen

Captura de pantalla 2025-05-29 a la(s) 9 39 37 a m

Desktop screen

Captura de pantalla 2025-05-29 a la(s) 9 39 09 a m

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label May 28, 2025
@openedx-webhooks
Copy link

Thanks for the pull request, @jacobo-dominguez-wgu!

This repository is currently maintained by @openedx/committers-frontend-app-learning.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.


Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@codecov
Copy link

codecov bot commented May 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.41%. Comparing base (d14c2a9) to head (d6fa564).
Report is 6 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1718   +/-   ##
=======================================
  Coverage   90.41%   90.41%           
=======================================
  Files         343      343           
  Lines        5781     5781           
  Branches     1385     1347   -38     
=======================================
  Hits         5227     5227           
- Misses        535      537    +2     
+ Partials       19       17    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jacobo-dominguez-wgu jacobo-dominguez-wgu added the mao-onboarding Reviewing this will help onboard devs from an Axim mission-aligned organization (MAO). label May 28, 2025
@jacobo-dominguez-wgu jacobo-dominguez-wgu moved this from Needs Triage to Ready for Review in Contributions May 28, 2025
@jacobo-dominguez-wgu jacobo-dominguez-wgu requested a review from a team May 28, 2025 21:20
Copy link
Contributor

@wgu-jesse-stewart wgu-jesse-stewart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! nice work

Copy link
Contributor

@wgu-jesse-stewart wgu-jesse-stewart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

after taking a second look, I think we need to either remove the flex-basis from the next-button or try a different approach.

@brian-smith-tcril
Copy link
Contributor

Could you include "before" screenshots in the PR description as well? Having "before" and "after" would make it a lot easier to see the difference quickly.

@jacobo-dominguez-wgu
Copy link
Contributor Author

Could you include "before" screenshots in the PR description as well? Having "before" and "after" would make it a lot easier to see the difference quickly.

Sure, screenshots added

Copy link
Contributor

@arbrandes arbrandes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks!

@arbrandes arbrandes merged commit 847d4e5 into openedx:master Jun 4, 2025
7 checks passed
@github-project-automation github-project-automation bot moved this from Ready for Review to Done in Contributions Jun 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mao-onboarding Reviewing this will help onboard devs from an Axim mission-aligned organization (MAO). open-source-contribution PR author is not from Axim or 2U

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants