-
Notifications
You must be signed in to change notification settings - Fork 295
feat(OEXCOM-80): disable completion item icons on flag #1714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(OEXCOM-80): disable completion item icons on flag #1714
Conversation
|
Thanks for the pull request, @holaontiveros! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1714 +/- ##
==========================================
+ Coverage 90.42% 90.43% +0.01%
==========================================
Files 344 344
Lines 5785 5793 +8
Branches 1348 1394 +46
==========================================
+ Hits 5231 5239 +8
+ Misses 537 535 -2
- Partials 17 19 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
arbrandes
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@holaontiveros, the code looks good, thanks!
Can you please include step-by-step testing instructions in the PR, though? Assume the reviewer has a standard Tutor dev environment with the demo course loaded and this PR checked out and running, but nothing more.
@arbrandes Done, thank you |
arbrandes
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the test instructions! This works as intended, and the code is good. Approved!
fixes #1692
Description
Currently when the ENABLE_COMPLETION_TRACKING_SWITCH waffle switch is disabled the frontend doesn't take it into account and still displays completion for anything that was already completed.
This PRs uses the same API fo the sidebar toggles that already exists where in this PR for edx-platform was added the current status of the switch and based on that it changes how the "completion status" it's shown, which it would be the default for nothing being touched at that point on the course
Testing instructions
Assumptions:
Steps:
completion.enable_completion_trackingis on. (in a normal install you could find it here: http://local.openedx.io:8000/admin/waffle/switch/1/change/)completion.enable_completion_trackingScreenshots
flag disabled

flag enabled
