refactor: refactor code by creating 1 instance of header instead of 3 #1164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sundasnoreen12
force-pushed
the
sundas/INF-1020
branch
from
b28431d
to
ca983c2
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1164 +/- ##
==========================================
- Coverage 87.89% 87.88% -0.01%
==========================================
Files 264 264
Lines 4476 4481 +5
Branches 1123 1130 +7
==========================================
+ Hits 3934 3938 +4
- Misses 528 529 +1
Partials 14 14
☔ View full report in Codecov by Sentry. |
sundasnoreen12
requested review from
asadazam93,
AhtishamShahid,
muhammadadeeltajamul and
awais-ansari
awais-ansari
requested changes
Aug 21, 2023
src/tab-page/TabPage.jsx
Outdated
| )} | ||
|
|
||
| {/* courseStatus 'failed' and any other unexpected course status. */} | ||
| {(courseStatus !== 'loading' && courseStatus !== 'loaded' && courseStatus !== 'denied') && ( |
There was a problem hiding this comment.
!['loading', 'loaded', 'denied'].includes(courseStatus)
sundasnoreen12
force-pushed
the
sundas/INF-1020
branch
from
31e3b04
to
358c710
Compare
awais-ansari
approved these changes
Aug 21, 2023
muhammadadeeltajamul
approved these changes
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
INF-1020
Description
Fixed issue of