Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENT-8400] Add feature flag to display subtitle dropdown in search header and bump versions #382

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mahamakifdar19
Copy link
Contributor

@mahamakifdar19 mahamakifdar19 commented Mar 25, 2024

Description

Adds a feature flag to display the subtitle facet dropdown in search header NPM package.
Bumps the version of @edx/frontend-enterprise-catalog-search and all other dependent packages.

Ticket

ENT-8400

image

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

@mahamakifdar19 mahamakifdar19 marked this pull request as draft March 25, 2024 12:14
Copy link

codecov bot commented Mar 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.20%. Comparing base (bfb2f3b) to head (998d2d0).
Report is 1 commits behind head on main.

❗ Current head 998d2d0 differs from pull request most recent head 044ab57. Consider uploading reports for the commit 044ab57 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #382   +/-   ##
=======================================
  Coverage   85.20%   85.20%           
=======================================
  Files          37       37           
  Lines         669      669           
  Branches      203      203           
=======================================
  Hits          570      570           
  Misses         95       95           
  Partials        4        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mahamakifdar19 mahamakifdar19 marked this pull request as ready for review March 26, 2024 09:14
@mahamakifdar19 mahamakifdar19 changed the title [ENT-8400] Add feature flag to display subtitle dropdown in search header [ENT-8400] Add feature flag to display subtitle dropdown in search header and bump versions Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants