Skip to content

Made icons inside topic module tab accessible #756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Made icons inside topic module tab accessible #756

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
21d25b1
made icons inside topic module tab accessible
Mar 13, 2025
1bbb18d
fix: updated main content block id to make skip to content work corre…
May 15, 2025
b51da73
fix: lint error fixed
May 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix: lint error fixed
  • Loading branch information
Zubair Shakoor authored and Zubair Shakoor committed May 21, 2025
commit b51da73779a8c4b44dc67cc3ff52352676ad5cc2
1 change: 1 addition & 0 deletions src/components/TinyMCEEditor.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,6 +152,7 @@
relative_urls: false,
default_link_target: '_blank',
target_list: false,
placeholder: props.placeholder,

Check failure on line 155 in src/components/TinyMCEEditor.jsx

View workflow job for this annotation

GitHub Actions / tests 

'placeholder' is missing in props validation
images_upload_handler: uploadHandler,
setup,
}}
Expand Down
7 changes: 4 additions & 3 deletions src/discussions/in-context-topics/topic/Topic.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,16 +2,16 @@
import PropTypes from 'prop-types';

import classNames from 'classnames';
import { useParams } from 'react-router-dom';
import { useNavigate, useParams } from 'react-router-dom';

import { useIntl } from '@edx/frontend-platform/i18n';

import TopicStats from '../../../components/TopicStats';
import { Routes } from '../../../data/constants';
import { discussionsPath } from '../../utils';
import messages from '../messages';
import { useNavigate } from 'react-router-dom';


Check failure on line 14 in src/discussions/in-context-topics/topic/Topic.jsx

View workflow job for this annotation

GitHub Actions / tests 

More than 1 blank line not allowed
const Topic = ({
topic,
showDivider,
Expand All @@ -36,13 +36,14 @@
navigate(topicUrl());
}}
onKeyDown={(e) => {
if (e.key === "Enter" || e.key === " ") {
if (e.key === 'Enter' || e.key === ' ') {
e.preventDefault();
isSelected(topic.id);
navigate(topicUrl());
}
}}
aria-current={isSelected(topic.id) ? 'page' : undefined}
aria-selected={isSelected(topic.id)}
role="option"
tabIndex={(isSelected(topic.id) || index === 0) ? 0 : -1}
style={{ cursor: 'pointer' }}
Expand Down
Loading