fix: redirection to learners tab in inContext view #653
Conversation
|
Thanks for the pull request, @sohailfatima! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. Once you've signed the CLA, please allow 1 business day for it to be processed. After this time, you can re-run the CLA check by adding a comment here that you have signed it. If the problem persists, you can tag the |
openedx-webhooks
added
the
open-source-contribution
|
Hi @sohailfatima! Thanks for this contribution! Please let me know if you have any questions regarding submitting a CLA form. |
|
Please consider adding before and after screen recordings in description. |
There was a problem hiding this comment.
@sohailfatima The author name should be just simple text in the inContext sidebar view. Currently, implementation is not according to ticket requirements.
|
@awais-ansari @ayesha-waris fixed the issue. |
There was a problem hiding this comment.
@sohailfatima, You just need to add logic in this condition.
|
@sohailfatima Please rebase the branch. The current branch has some conflicts. |
sohailfatima
force-pushed
the
fatima/INF-1224
branch
from
8db03af
to
fb44238
Compare
sohailfatima
force-pushed
the
fatima/INF-1224
branch
from
fb44238
to
db8d116
Compare
|
Hi @sohailfatima! I'm just following-up to see if you've had a chance to submit a CLA form? |
mphilbrick211
added
the
needs test run
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #653 +/- ##
=======================================
Coverage 92.76% 92.76%
=======================================
Files 156 156
Lines 3303 3304 +1
Branches 902 903 +1
=======================================
+ Hits 3064 3065 +1
Misses 219 219
Partials 20 20 ☔ View full report in Codecov by Sentry. |
mphilbrick211
removed
the
needs test run
| @@ -90,6 +90,15 @@ describe('Author label', () => { | |||
| }, | |||
| ); | |||
|
|
|||
| it( | |||
| 'it is not clickable when enableInContextSidebar is true', | |||
There was a problem hiding this comment.
can be written in previous line
|
fixed in PR |
|
@sohailfatima Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future. |
INF-1224
Description
Fixed the issue of redirection to the learners tab within the inContext view when username is clicked from post details.
The username in the inContext view is now simple text.
Before:
Screen.Recording.2024-01-25.at.11.22.17.PM.mov
After:
Screen.Recording.2024-01-25.at.11.21.08.PM.mov